Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes #22

Closed
jsiebern opened this issue Jan 22, 2014 · 1 comment
Closed

Some fixes #22

jsiebern opened this issue Jan 22, 2014 · 1 comment

Comments

@jsiebern
Copy link

Hi, I know this script is pretty old but I needed something like this in a project of mine and I made some fixes to it to work with the newer browser versions.


if (!selector || ruleText === selector || ruleText === jss._swapAdjSelAttr(selector)) {

if (!selector || ruleText === selector || ruleText === jss._swapAdjSelAttr(selector) || ruleText === selector.replace(':','::')) {


result[propName] = rules[i].style[propName];

result[propName] = rules[i].style[propName] || rules[i].style[jss._toCamelCase(propName)];

Just 2 very quick fixed, the first one is for selecting pseudo classes in Chrome, the second one is for the get function to receive the correct data in FF.

This is far from completely working now, for example margin values are incorrect in FF, probably padding as well but I don't need those for now ;-)

In case anyone uses this still...

@editht
Copy link
Collaborator

editht commented Mar 23, 2014

Thanks for the feedback, JSS has been updated to handle browser inconsistencies with regards to pseudo element syntax in version 0.6. Any calls to JSS should be made using the correct double colon syntax for pseudo elements.

@editht editht closed this as completed Mar 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants