Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'minimize to tray' and fixed native controls in popups #86

Closed
wants to merge 9 commits into from
Closed

Add 'minimize to tray' and fixed native controls in popups #86

wants to merge 9 commits into from

Conversation

stamoun
Copy link
Collaborator

@stamoun stamoun commented Oct 6, 2020

Fixes for issues #80 and #83

The workspace settings doesn't work, nor is .prettierrc.json... :|
- Added `show in taskbar` setting
- Apply new settings without reloading
- Only reset user-modifiable settings when resetting to factory defaults (i.e. do not remove the auth tokens)
- Fixed white background when closing the debug console
Use native titlebar buttons
This hides the min/max buttons when disabled
@stamoun
Copy link
Collaborator Author

stamoun commented Oct 6, 2020

FYI I tested this on both win10 and ubuntu 20.04.1 with a gnome shell. I did not test this on MacOS (I don't own a Mac sadly), so if you could test the change on Mac, I'd appreciate it :)

Focusable will always be true
This causes bug #87
@stamoun
Copy link
Collaborator Author

stamoun commented Oct 7, 2020

Be aware that this PR causes bug #87 on Linux (workaround: use alt/super key to drag the window past the boundary)

@stamoun
Copy link
Collaborator Author

stamoun commented Oct 8, 2020

Merging this PR with PR #88

@stamoun stamoun closed this Oct 8, 2020
dvx added a commit that referenced this pull request Jan 23, 2021
Like/Unlike Implementation #43, Minimize to Tray #86 and Fix for Native Title Bar #83
@dvx dvx mentioned this pull request Jan 23, 2021
@stamoun stamoun deleted the minimize-to-tray-80 branch September 7, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant