Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native title bar #83

Closed
fregante opened this issue Oct 2, 2020 · 1 comment · Fixed by #100
Closed

Use native title bar #83

fregante opened this issue Oct 2, 2020 · 1 comment · Fixed by #100

Comments

@fregante
Copy link

fregante commented Oct 2, 2020

I noticed that the minimize/close buttons in the title bar were reimplemented. Why not just use the native controls? This doesn't fit macOS style:

I think Electron offers a macOS-specific option to just display the "traffic lights" controls instead of the whole bar.
@dvx
Copy link
Owner

dvx commented Oct 2, 2020

Thanks for the heads-up, will look into this! I forget the exact reason I didn't (couldn't?) use a native frame.

This was referenced Oct 6, 2020
Closed
Merged
dvx added a commit that referenced this issue Jan 23, 2021
@dvx
Merge pull request #88 from stamoun/like-43
7ffec64 
Like/Unlike Implementation #43, Minimize to Tray #86 and Fix for Native Title Bar #83
@dvx dvx mentioned this issue Jan 23, 2021
Merged
@dvx dvx closed this as completed in #100 Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

@stamoun like-43 branch PR dvx/lofi
2 participants
@dvx @fregante