-
-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cannot install in another folder #65
Comments
It depends where you clone KIAUH into. You aren't forced to clone KIAUH in the home directory. |
yes i mean clone into another directory than home. i can clone the repository in another folder. but the script cannot work. cause it seeking in HOME directory. i try with create folder ".kiauh" and failed. and then trying again with folder "installer" the error after cloning and execute the script is like below
|
You are right. There is a hardcoded ${HOME} in the code. Thanks for pointing that out, i will fix the issue and check the script if there are any other spots where i made the same mistake. |
emm it is a little weird. i run the kiauh.sh in the separeted folder (let's say in the "installer" folder) and it is force to create the installation in the home root directory instead in the installer directory? |
What installation are you talking about now exactly? |
sorry to make you confused about this... i will told you what i have do
the installation of the klipper, moonraker, and fluidd (cause i install fluidd only) is in the home directory. (/home/octoprint/ in my case), when it supposed need to install in the simple directory (/home/octoprint/simple) that's why i ask you, are this script force to install in the home directory? i already tried your newest project. it still force install the klipper, moonraker and the fluid in the home directory. sorry for my bad english, install might means where you save the klipper, moonraker and fluid code |
Now i get what you mean. 😄 And yes, klipper, moonraker and fluidd (and everything else) gets installed to the home directory. That is hardcoded and that won't get changed, i'm sorry. |
As a feature request and alternative to allowing arbitrary install locations, perhaps KIAUH could respect the XDG Base Directory Specification if the requisite env vars were set. I may fork KIAUH to try to implement this, and would be happy to submit a PR if @dw-0 was open to it. |
i would like to kinda refrain from using any specification in terms of files or directories to be honest. The issue is almost 3 years old and my view has changed a bit. So IF we allow different installation directories, how about NOT enforcing any specific (base) directory? as some might have noticed, there is a kiauh rewrite ongoing. at a later stage, i plan to add support for custom installation directories. which should be rather easy to implement afterwards. there is an issue here: #372 that is also added to the milestones already. |
@dw-0 Thanks for the response. Yeah, there's good arguments for not enforcing a particular spec, and taking that approach means folk who want their files in a particular dir (like the XDG_XXXXX_HOME dirs) can do so anyway! I'll check out the new linked issue, many thanks. |
looks like it cannot change to another folder than home directory.
is there any hard coded home path besides in kiauh.sh?
i try to install in folder "installer" cause it will make my folder clean and not make confused.
The text was updated successfully, but these errors were encountered: