sbt script no longer working on OS X

[purefn]

Since commit 34c7370, readarray has been used to read the .jvmopts and .sbtopts files. Unfortunately, it seems this builtin bash command isn't available on OS X because it uses an older bash.

One solution is to use read in a while loop, as described on this SO answer.

[jedws]

The associated PR appears to be sound. Any reason not to merge?

[jedws]

even the brew installed bash doesn't include readarray, making it painful to set project specific jvmopts on MacOS

[gildegoma]

I'm a bit concerned by this issue, because I also fall in that pit. In 3e34bce of PR #43, I actually propose to add a dependency check on bash version, and refuse to run with bash elder than version 4. Here are a few more inputs about this integration problem:

• Indeed, Mac OS X 10.7 ships bash 3.2.48, released in 2007! (I did not check 10.8). Bash 4 (which introduced readarray built-in) came out in february 2009 already! Mmmh... Bash 3 is GPL v2, while Bash 4 is licensed under GPL v3. I let you compare philosophies between *BSD or Linux distributions, IBM AIX and 🍎 ... and make your opinion.
• Hopefully homebrew provides bash 4.x for quite some time. Thanks homebrew to save OS X!
  • @jedws (even the brew installed bash doesn't include readarray...): I think you should have something wrong in your brew configuration... it works like a charm for me.

@paulp should decide if default portability (over "ages") or bash comfort should be privileged... I prefer the second way, which is more modern and elegant in my opinion!

[jedws]

@gildegoma I couldn't get it working for some reason, but all I really wanted was to get enough memory for SBT and didn't spend a lot of time on it. At the moment I'm resorting to hacking the sbt-extras script to do so. Diagnosing the problem was the real time-sink.

[gildegoma]

@jedws I perfectly understand your point. If this PR is not accepted, sbt-extras should check and claim "bash 4" requirement to avoid such annoying situation.

[gildegoma]

PR #46 has been merged, this issue can be closed.

[paulp]

For the record, the reason this situation can arise given that I am on OSX all the time is that I'm also using bash4 all the time. It's not my intention to require bash4, but neither is this project a high enough priority for me for me to do much beyond my own requirements. In any case I take it it's fixed, which is good.