Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pages module #11

Open
SimonLab opened this issue Feb 25, 2020 · 0 comments
Open

Create pages module #11

SimonLab opened this issue Feb 25, 2020 · 0 comments
Assignees
Projects

Comments

@SimonLab
Copy link
Member

Currently the Main.elm file contains all the logic of the application.
We have only 3 kind of pages but with new features coming this will certainly rapidly grow (e.g capture page, categorise page, about page, ...):

app-mvp-elm/src/Main.elm

Lines 31 to 34 in 7507bab

type Page
= Home
| Auth (Maybe String)
| NotFound

If we keep all the logic of the pages in the Main module it will be difficult to navigate the code.

Based on the projects structure of

creating a module per page seems to be a good idea to manage the logic specific to a route.

@SimonLab SimonLab added the T1h label Feb 25, 2020
@SimonLab SimonLab self-assigned this Feb 25, 2020
@SimonLab SimonLab added this to To do in dwyl app via automation Feb 25, 2020
@SimonLab SimonLab moved this from To do to In progress in dwyl app Feb 26, 2020
SimonLab added a commit that referenced this issue Feb 27, 2020
SimonLab added a commit that referenced this issue Feb 27, 2020
@SimonLab SimonLab added T1d and removed T1h labels Feb 27, 2020
@SimonLab SimonLab moved this from In progress to Awaiting review in dwyl app Feb 27, 2020
SimonLab added a commit that referenced this issue Feb 27, 2020
@nelsonic nelsonic moved this from Awaiting review to Done in dwyl app Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
dwyl app
  
Done
Development

No branches or pull requests

1 participant