Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create module per page #12

Merged
merged 3 commits into from
Feb 27, 2020
Merged

create module per page #12

merged 3 commits into from
Feb 27, 2020

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Feb 27, 2020 •
edited
Loading

ref: #11

  • Create Home and Auth page
  • Create Route page which map the browser url to a specific type

@SimonLab SimonLab self-assigned this Feb 27, 2020
SimonLab
SimonLab commented Feb 27, 2020
View reviewed changes
src/Main.elm
, authUrls : List Url
, token : String

-- , token : String
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This token will be contained in a Session module, see #13

SimonLab
SimonLab commented Feb 27, 2020
View reviewed changes
src/Main.elm
Comment on lines +104 to +105
-- could we create an Error module which will manage this kind of pages
-- see package elm app
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary at the moment, I've updated this on #13

@SimonLab SimonLab assigned nelsonic and unassigned SimonLab Feb 27, 2020
nelsonic
nelsonic approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab code looks great! 🎉

@nelsonic nelsonic merged commit 01a5dd9 into master Feb 27, 2020
@nelsonic nelsonic deleted the page-modules-#11 branch February 27, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels
awaiting-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SimonLab @nelsonic