PR: Remove --base-href /app/ for #322 when using subdomain app.dwyl.com
#324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonic
added
the
help wanted
|
Yes, it probably will. I had to add If you've changed the domain, deleting this should work. You probably have to wait to propagate the DNS and hard refresh to test if it's working properly. |
LuchoTurtle
approved these changes
Mar 2, 2023
|
The site is working.
|
nelsonic
commented
Mar 2, 2023
|
Oki doki. Merging, as it it's working. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will this address the issue described in: #322 (comment)
Please check @LuchoTurtle 🙏