Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createReadStream buffer support #52

Closed
MrHen opened this issue Oct 25, 2016 · 3 comments
Closed

createReadStream buffer support #52

MrHen opened this issue Oct 25, 2016 · 3 comments
Labels
enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment!

Comments

@MrHen
Copy link
Collaborator

MrHen commented Oct 25, 2016

I opened a PR to add .createReadStream support: #50

The basic functionality is:

    awsMock.mock('S3', 'getObject', new Buffer('body'));
    var s3 = new AWS.S3();
    var req = s3.getObject('getObject', {});
    var stream = req.createReadStream();
    stream.pipe(concatStream(function(actual) {
      st.equals(actual.toString(), 'body')
      awsMock.restore('S3', 'getObject');
      st.end();
    }));
@MrHen MrHen changed the title createReadStream support createReadStream buffer support Oct 25, 2016
@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! labels Oct 26, 2016
@MrHen
Copy link
Collaborator Author

MrHen commented Nov 4, 2016

@nelsonic Not sure what help is needed for this ticket. The PR is ready to go. Is there someone else I can ping who can look at this and merge it?

@MrHen
Copy link
Collaborator Author

MrHen commented Nov 16, 2016

@nikhilaravi
@jruts
@jcready
@motiz88
@nelsonic

Sorry to ping all of you but I'm not sure which of you is the right person to ask for a merge. If no one has time or interest, feel free to add me as a contributor.

@MrHen MrHen closed this as completed Nov 16, 2016
@nelsonic
Copy link
Member

@MrHen merged and added you as a colaborator. (not so that you can merge your own PRs, just so that you can review anyone else's in the future and can create branches directly in the project) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment!
Projects
None yet
Development

No branches or pull requests

2 participants