-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add createReadStream payload support #50
Conversation
@@ -48,6 +48,7 @@ test('AWS.mock function should mock AWS service and method on the service', func | |||
s3.getObject({Bucket: 'b', notKey: 'k'}, function(err, data) { | |||
st.ok(err); | |||
st.notOk(data); | |||
awsMock.restore('S3', 'getObject'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why these were missing and/or necessary but later tests would not get the appropriate mocks unless these restore
calls were added.
Current coverage is 99.10% (diff: 100%)
|
@nelsonic not sure what the normal PR procedure is for this repo. Anything in particular I need to do? |
👍 Would like to see this as well. |
When can we expect this to be merged? |
This is a very useful feature. Could we have it merged please? |
@MrHen thanks very much for adding this feature. (really sorry to keep you waiting for the PR...) |
@MrHen new version on NPM: |
@nelsonic Thanks! Sorry for pestering so much. :) |
@MrHen not at all. you did a superb job of adding the functionality with tests! ❤️ (thanks!) |
I have a scenario where I need to test S3 streams. This feature would save me a lot of trouble.