Adding Information on How to connect Github to Atom #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I Think its important to explain to everyone how they can connect GitHub to Atom and how they can edit Github files from there.
nelsonic
added
the
awaiting-review
nelsonic
requested changes
Jan 8, 2020
There was a problem hiding this comment.
@miguelmartins17 this is a really good addition for people who are new to using GitHub with Atom. 🎉
The only improvements I would make are:
- when explaining something for a @dwyl tutorial repository, try to use a dwyl repository in the example.
You're using https://github.com/miguelmartins17/testrep hen you can easily use https://github.com/dwyl/dev-setup for consistency. - If you can constrain a screenshot to only show the essential information and no extra parts of the screen that do not add any information, do it. The smaller the screenshots the less bandwidth is used downloading them and the less time people waste scrolling.
Please see: https://github.com/dwyl/dev-setup/blob/af38341a822a0ba7dc693bd5e0313983f088fea8/readme.md#how-to-connect-github-to-atom-step-by-step
Some of the screenshots are huge when the could be constrained. e.g:
Could be cut down to a fraction of the size without losing any significance:
These may seem like minor issues that are not worth "fixing".
But remember that the first item on @dwyl's mission is to "never waste anyone's time".
That means optimising each step to avoid any unnecessary effort (wasted time).
In this case the content you have created is really good. ✅
It can just be "tightened" up to improve the speed that the reader will view it. 👍
nelsonic
added
in-progress
|
@nelsonic I'm going to Update this right now please when you have time give me a feedback about this. 👋 |
Updating This Repository
nelsonic
added
awaiting-review
nelsonic
approved these changes
Jan 13, 2020
This was referenced Apr 15, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I Think its important to explain to everyone how they can connect GitHub to Atom and how they can edit Github files from there.