-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Landing page HTML and CSS #244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Cleop looks great! 🎉
<textarea id="message" name="message" class="br2 bw1 w-90 dwyl-b--dark-grey pa2" rows="10" placeholder="What problem can we solve for you?"></textarea> | ||
</fieldset> | ||
|
||
<button class="bn dib link mv2 ml3 ph3 pv3 dwyl-bg-mint white br2 f4 shadow-4"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add the pointer
class on the button?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we centre this button on mobile?
<h1 class="mt0-ns mb3 pl4-ns f-xl tl fw9">Let's</h1> | ||
<h1 class="pl4-ns mt3 f-xl tl fw9">Talk</h1> | ||
</div> | ||
<div class="w-80-ns w-90 ml3"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add some links with mailto
, tel
and google maps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</div> | ||
</ul> | ||
</div> | ||
<a href="#" class="dib link mt2 mb4 ml4 ml3-ns ml6-ns ph4 pv2 dwyl-bg-mint white br2 f5 shadow-4">Enquire Now</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we centre this link on mobile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👌 . I've added a few comments which can be addressed on the next issues. @iteles do you have any other feedback?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<title>dwyl</title> | ||
</head> | ||
<body> | ||
<h1>Hello world!</h1> | ||
<nav class="w-100 vh-100 h3-ns dwyl-bg-dark-grey tc white"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only partial support in IE for vh
and I know this caused @RobStallion some issues on FREED - please test this in IE10 + 11 (@Danwhy has a good way of doing this with saucelabs manual testing and https://ngrok.com/ )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been removed as a rem unit is now suitable with the new design.
<meta name="keywords" content="do, what, you, love, dwyl, mvp, time, tracking, help, developers, code, frontend, backend, tooling, tools"> | ||
<meta name="robots" content="index, follow, noarchive"> | ||
<meta name="base" content="https://www.dwyl.com"> | ||
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/font-awesome/4.4.0/css/font-awesome.min.css"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to consider a customised version of fontawesome at a later stage when we have a back end if we feel there are performance benefits from it.
<h1 class="mt0-ns mb3 pl4-ns f-xl tl fw9">Let's</h1> | ||
<h1 class="pl4-ns mt3 f-xl tl fw9">Talk</h1> | ||
</div> | ||
<div class="w-80-ns w-90 ml3"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback 👍 I've spoken to @harrygfox to get his feedback. Now I'll create new issues for amends to be made. Following this, the Values page will be next. |
#241
Creates desktop navbar
Creates top 'We Make Excellent Products' banner with white boxes
Creates 'We can make your MVP' banner (without diagonal styling)
Creates 'The Right Solution' section
Creates Training + Workshops section
Creates contact section
Creates footer section
Adds font awesome, Redesign: Add font awesome and respective icons #248
Adds correct font, Redesign: font throughout #245
Covers 'Training + Workshops' for screen readers, Redesign: does 'Training + Workshops' work for screen readers? #243
The burger for the mobile menu and that functionality is being addressed in a separate issue #249