Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding reviewers, but not ready for review #122

Closed
samhstn opened this issue Jun 21, 2017 · 4 comments
Closed

Adding reviewers, but not ready for review #122

samhstn opened this issue Jun 21, 2017 · 4 comments

Comments

@samhstn
Copy link
Member

samhstn commented Jun 21, 2017

@SimonLab see here

Also dwylbot seems to have added too many awaiting-review labels here

@SimonLab
Copy link
Member

Thanks @Shouston3 for reporting this 👍 . I will add a condition to not assign and not add "awaiting-review" if the pr has the "in-progress" label.
We are discussing when is a good time to add reviewers on a PR, see #116 , please add your thought it can help me to calibrate the rule

@samhstn
Copy link
Member Author

samhstn commented Jun 21, 2017

I guess according to #116 I shouldn't be adding reviewers until things are ready to be reviewed
I personally like knowing what I'm going to review as soon as possible even if it isn't ready, but it seems like I'm alone with this

closing

@SimonLab
Copy link
Member

I reopen this, as I haven't finished to add a filter on the rule to check the in-progress label. I think you have a good point too and we will need more feedback o see how other users add reviewers

@ghost
Copy link

ghost commented Sep 20, 2017

👍

@ghost ghost closed this as completed Sep 20, 2017
@jammur jammur unassigned ghost Dec 14, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants