Tidying up the Readme + Usage Screenshots #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
|
|
A better example of Linting errors: |
|
Auto-fix: |
nelsonic
changed the title
iteles
reviewed
Dec 4, 2016
|
|
||
| > "_Any fool can write code that a computer can understand. | ||
| > "_Any fool can write code that a computer can understand. <br /> |
iteles
reviewed
Dec 4, 2016
| "Old" Browsers/Devices are a _fact_, even if it's "*only a small percentage*" | ||
| of people, we _chose_ to | ||
| [*empathize*](http://www.merriam-webster.com/dictionary/empathize) | ||
| with them by writing code that ***Works Everywhere***<sup>TM</sup>. | ||
|
|
||
| 3. ***Beginner-friendlyness*** or [***Shoshin***](https://en.wikipedia.org/wiki/Shoshin) - using _fewer_ JS features |
There was a problem hiding this comment.
Mis-spelling of friendliness but I plan to review the goodparts readme more fully in the coming days so I will correct then.
iteles
reviewed
Dec 4, 2016
| A one-line install that will ensure your project's code works everywhere. | ||
| (_or your money back!_) | ||
| `goodparts` is a "[linter](https://en.wikipedia.org/wiki/Lint_%28software%29)" | ||
| that _ensures_ your project's JavaScript code <br > |
There was a problem hiding this comment.
I don't think <br>s are necessary here but will suggest removing them later.
iteles
reviewed
Dec 4, 2016
| @@ -26,8 +26,8 @@ function ruleNotConfigured (rule) { | |||
| } | |||
|
|
|||
| test('Testing All Conifgurable Rules', function (t) { | |||
There was a problem hiding this comment.
Spelling mistake here which I'll pick up in my review later in the week 👍
|
🎉 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a couple of rules: (both set to "off")
require-awaitrequire-await #277capitalized-commentscapitalized-comments #278Also tidied up the Readme a bit (removed some bloat) and added usage example screenshots: #263