New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try mode #112
Conversation
|
@alanshaw when you get a chance please confirm this works for you. thanks! |
|
LGTM - the tests in my application pass with 5.1.0, fail with 5.1.1 and pass again using this branch. |
|
@alanshaw thanks for confirming that, are you happy for us to |
|
Please do! |
|
Done! |
|
Shipped. |
|
plz check your gitter messages |
|
@alanshaw sec report filed. thanks for the advice. |
Adds regression test for
tryandoptionalauth modes.see: #111
Without the lines:
it actually works exactly as expected.
Confirmed by the master in: hapijs/hapi#2843
@alanshaw I took the regression tests directly from your branch: alanshaw@736067f👍
please
checkoutthis branch and confirm it works as expected.Thanks.