-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Filenames on S3
should be the cid
of the content ...
#62
Comments
With the changes introduced in Lines 22 to 27 in 2f51c88
|
The upload.ex is only used for the API. |
Because the current code used in the In order to not lose the previous work made, I'm going to create a new page that is "clientless", which uses the |
Indeed the guide written by Chris https://github.com/phoenixframework/phoenix_live_view/blob/v0.19.3/guides/server/uploads.md#L1 uses the If you end up making a "clientless" version that uses the |
The closed PR #64 directly addresses this. It generates the |
And yes, I'm doing the "clientless" version now on a different live view page. I want to get this done before doing other issues (like the image classifier) so I can have a more solid foundation to work on it. I'm branching off from #86 (review) so I don't have merge conflicts later on 👌 |
# Conflicts: # test/app_web/api_test.exs
idk how this was changed in the first place.
At present Unique File Names are using
DateTime.utc_now()
:This is does not take advantage of
cid
.The idea of
cid
is that when a file is uploaded the name of the file is based on the actual content of the file ...Therefore we need to read the binary of the file and feed that into
cid/1
such that when the same file is uploaded again, it will have the same filename onS3
.The reason we want to do this is simple: we avoid duplicates.
Todo
key
variable to use acid
of the actual contents of the file.The text was updated successfully, but these errors were encountered: