[PR] Addressing edge cases #86

LuchoTurtle · 2023-06-28T14:17:18Z

closes #69

This adds pattern matching and returns the person meaningful error messages according to whether there was an error:

reading the path from the image.
creating the CID from the file contents.
getting the file extension.
uploading the file to S3.

I had to use mock to force the request to S3 to fail in tests and to emulate invalid binary data so CID would also fail, as detailed in #69.

LuchoTurtle · 2023-06-28T14:57:42Z

This should be reviewable now 🆗

nelsonic

Going to make a couple of adjustments. 🧑‍💻
Thanks for proactively opening this PR. 👍

nelsonic · 2023-07-04T13:56:19Z

On my localhost, ran the following:

git pull 
git checkout 'edge-cases-#69'
mix deps.get
source .env
mix c

Got:

  1) test upload/1 happy path REAL Upload (App.UploadTest)
     test/app/upload_test.exs:4
     Assertion with == failed
     code:  assert App.Upload.upload(image) == {:ok, expected_response}
     left:  {:error, :upload_fail}
     right: {:ok, %{compressed_url: "https://s3.eu-west-3.amazonaws.com//zb2rhXACvyoVCaV1GF5ozeoNCXYdxcKAEWvBTpsnabo3moYwB.png", url: "https://s3.eu-west-3.amazonaws.com//zb2rhXACvyoVCaV1GF5ozeoNCXYdxcKAEWvBTpsnabo3moYwB.png"}}
     stacktrace:
       test/app/upload_test.exs:18: (test)



  2) test upload with image keyword (AppWeb.APITest)
     test/app_web/api_test.exs:64
     ** (RuntimeError) expected response with status 200, got: 400, with body:
     "{\"errors\":{\"detail\":\"Error uploading file. There was an error uploading the file to S3.\"}}"
     code: assert Jason.decode!(response(conn, 200)) == expected
     stacktrace:
       (phoenix 1.7.6) lib/phoenix/test/conn_test.ex:373: Phoenix.ConnTest.response/2
       test/app_web/api_test.exs:74: (test)

..

  3) test upload succeeds (happy path) (AppWeb.APITest)
     test/app_web/api_test.exs:51
     ** (RuntimeError) expected response with status 200, got: 400, with body:
     "{\"errors\":{\"detail\":\"Error uploading file. There was an error uploading the file to S3.\"}}"
     code: assert Jason.decode!(response(conn, 200)) == expected
     stacktrace:
       (phoenix 1.7.6) lib/phoenix/test/conn_test.ex:373: Phoenix.ConnTest.response/2
       test/app_web/api_test.exs:61: (test)

..........
Finished in 0.2 seconds (0.1s async, 0.1s sync)
15 tests, 3 failures

Randomized with seed 654535
----------------
COV    FILE                                        LINES RELEVANT   MISSED
100.0% lib/app.ex                                      9        0        0
100.0% lib/app/repo.ex                                 5        0        0
 90.0% lib/app/upload.ex                             108       20        2
100.0% lib/app_web/components/layouts.ex               5        0        0
 90.0% lib/app_web/controllers/api_controller.e       46       10        1
 66.7% lib/app_web/controllers/api_json.ex            20        3        1
100.0% lib/app_web/controllers/page_controller.       25        5        0
100.0% lib/app_web/controllers/page_html.ex            5        0        0
100.0% lib/app_web/endpoint.ex                        48        0        0
100.0% lib/app_web/live/imgup_live.ex                 93       26        0
100.0% lib/app_web/router.ex                          30        4        0
100.0% lib/app_web/s3_upload.ex                      127       24        0
[TOTAL]  95.7%
----------------
Generating report...
Saved to: cover/
FAILED: Expected minimum coverage of 100%, got 95.7%.

LuchoTurtle · 2023-07-04T14:35:44Z

Does your .env file have the following format?

export AWS_ACCESS_KEY_ID='XXXX'
export AWS_SECRET_ACCESS_KEY='XXX'
export AWS_REGION='eu-XX-3'
export AWS_ORIGINAL_BUCKET='imgup-XX'
export AWS_COMPRESSED_BUCKET='imgup-XX'

LuchoTurtle · 2023-07-04T14:38:37Z

Nevermind.
The API is not working correctly...

The old problem where we need to update the secrets remotely is happening again :/

LuchoTurtle · 2023-07-04T14:40:43Z

It seems the bucket env variables are not being correctly loaded when deploying, according to the logs on fly.io.

 [error] ** (RuntimeError) Elixir.ExAws.Operation.ExAws.Operation.S3.perform/2 cannot perform operation on `nil` bucket

https://fly.io/apps/imgup/monitoring

nelsonic · 2023-07-04T17:11:39Z

The buckets need to be set on Fly.io: https://fly.io/apps/imgup/secrets

The values of the Bucket Environment Variables aren't secret; they appear in the URL ... 🔗 😉
So we don't need to obfuscate/hide them.
Just advise people to replace them with their own values.

flyctl secrets set AWS_ORIGINAL_BUCKET=imgup-original -a imgup
flyctl secrets set AWS_COMPRESSED_BUCKET=imgup-compressed -a imgup

Updated:

But still getting the error:

Couldn't upload files to S3. Open an issue on Github and contact the repo owner.

as noted in: #69 (comment)

nelsonic · 2023-07-04T17:20:02Z

With the env vars as required:

export AWS_ACCESS_KEY_ID=AKIAetc.
export AWS_SECRET_ACCESS_KEY=aietc.
export AWS_REGION='eu-west-3'
export AWS_ORIGINAL_BUCKET='imgup-original'
export AWS_COMPRESSED_BUCKET='imgup-compressed'

Still get:

mix c


  1) test upload with image keyword (AppWeb.APITest)
     test/app_web/api_test.exs:64
     Assertion with == failed
     code:  assert Jason.decode!(response(conn, 200)) == expected
     left:  %{"compressed_url" => "https://s3.eu-west-3.amazonaws.com//zb2rhXACvyoVCaV1GF5ozeoNCXYdxcKAEWvBTpsnabo3moYwB.png", "url" => "https://s3.eu-west-3.amazonaws.com/imgup-original/zb2rhXACvyoVCaV1GF5ozeoNCXYdxcKAEWvBTpsnabo3moYwB.png"}
     right: %{
              "compressed_url" => "https://s3.eu-west-3.amazonaws.com/imgup-compressed/zb2rhXACvyoVCaV1GF5ozeoNCXYdxcKAEWvBTpsnabo3moYwB.png",
              "url" => "https://s3.eu-west-3.amazonaws.com/imgup-original/zb2rhXACvyoVCaV1GF5ozeoNCXYdxcKAEWvBTpsnabo3moYwB.png"
            }
     stacktrace:
       test/app_web/api_test.exs:74: (test)

....

  2) test upload/1 happy path REAL Upload (App.UploadTest)
     test/app/upload_test.exs:4
     Assertion with == failed
     code:  assert App.Upload.upload(image) == {:ok, expected_response}
     left:  {:ok, %{compressed_url: "https://s3.eu-west-3.amazonaws.com//zb2rhXACvyoVCaV1GF5ozeoNCXYdxcKAEWvBTpsnabo3moYwB.png", url: "https://s3.eu-west-3.amazonaws.com/imgup-original/zb2rhXACvyoVCaV1GF5ozeoNCXYdxcKAEWvBTpsnabo3moYwB.png"}}
     right: {
              :ok,
              %{
                compressed_url: "https://s3.eu-west-3.amazonaws.com/imgup-compressed/zb2rhXACvyoVCaV1GF5ozeoNCXYdxcKAEWvBTpsnabo3moYwB.png",
                url: "https://s3.eu-west-3.amazonaws.com/imgup-original/zb2rhXACvyoVCaV1GF5ozeoNCXYdxcKAEWvBTpsnabo3moYwB.png"
              }
            }
     stacktrace:
       test/app/upload_test.exs:18: (test)



  3) test upload succeeds (happy path) (AppWeb.APITest)
     test/app_web/api_test.exs:51
     Assertion with == failed
     code:  assert Jason.decode!(response(conn, 200)) == expected
     left:  %{"compressed_url" => "https://s3.eu-west-3.amazonaws.com//zb2rhXACvyoVCaV1GF5ozeoNCXYdxcKAEWvBTpsnabo3moYwB.png", "url" => "https://s3.eu-west-3.amazonaws.com/imgup-original/zb2rhXACvyoVCaV1GF5ozeoNCXYdxcKAEWvBTpsnabo3moYwB.png"}
     right: %{
              "compressed_url" => "https://s3.eu-west-3.amazonaws.com/imgup-compressed/zb2rhXACvyoVCaV1GF5ozeoNCXYdxcKAEWvBTpsnabo3moYwB.png",
              "url" => "https://s3.eu-west-3.amazonaws.com/imgup-original/zb2rhXACvyoVCaV1GF5ozeoNCXYdxcKAEWvBTpsnabo3moYwB.png"
            }
     stacktrace:
       test/app_web/api_test.exs:61: (test)

........
Finished in 1.2 seconds (1.1s async, 0.1s sync)
15 tests, 3 failures

Randomized with seed 88516
----------------
COV    FILE                                        LINES RELEVANT   MISSED
100.0% lib/app.ex                                      9        0        0
100.0% lib/app/repo.ex                                 5        0        0
100.0% lib/app/upload.ex                             108       20        0
100.0% lib/app_web/components/layouts.ex               5        0        0
100.0% lib/app_web/controllers/api_controller.e       46       10        0
100.0% lib/app_web/controllers/api_json.ex            20        3        0
100.0% lib/app_web/controllers/page_controller.       25        5        0
100.0% lib/app_web/controllers/page_html.ex            5        0        0
100.0% lib/app_web/endpoint.ex                        48        0        0
100.0% lib/app_web/live/imgup_live.ex                 93       26        0
100.0% lib/app_web/router.ex                          30        4        0
100.0% lib/app_web/s3_upload.ex                      127       24        0
[TOTAL] 100.0%
----------------
Generating report...
Saved to: cover/

The URL in the tests is:

https://s3.eu-west-3.amazonaws.com//zb2rhXACvyoVCaV1GF5ozeoNCXYdxcKAEWvBTpsnabo3moYwB.png

The bucket is being omitted ... 😕

https://github.com/dwyl/imgup/blob/0366a9184f404115fb3c18c17cd90eebc04aaafa/test/app_web/api_test.exs#L43C13-L48

@LuchoTurtle happy to show you this at my desk.

LuchoTurtle · 2023-07-04T17:27:59Z

This is most definitely an issue regarding env variables, which are not being correctly loaded. Perhaps restarting/redeploying might help?

nelsonic · 2023-07-05T09:27:38Z

Ok. We are looking at two separate (but apparently related) issues here.

The tests don't pass on my localhost.
S3 Bucket environment variables are not set on Fly.io.

I'm going to figure out localhost first.
I have the environment variables defined correctly.
When I run printenv I see the following:

...
HOMEBREW_PREFIX=/opt/homebrew
HOMEBREW_CELLAR=/opt/homebrew/Cellar
HOMEBREW_REPOSITORY=/opt/homebrew
MANPATH=/opt/homebrew/share/man::
INFOPATH=/opt/homebrew/share/info:
ANDROID_HOME=/Users/n/Library/Android/sdk
AWS_ACCESS_KEY_ID=AWS
AWS_SECRET_ACCESS_KEY=aitookourjobs
AWS_REGION=eu-west-3
AWS_ORIGINAL_BUCKET=imgup-original
AWS_COMPRESSED_BUCKET=imgup-compressed
_=/usr/bin/printenv

Checked the spelling on the env vars AWS_ORIGINAL_BUCKET

and AWS_COMPRESSED_BUCKET:

Ran: MIX_ENV=test mix compile --force

Got the following warning:

warning: Application.get_env/2 is discouraged in the module body, use Application.compile_env/3 instead
  lib/app/upload.ex:7: App.Upload

This relates to the following lines:
https://github.com/dwyl/imgup/blob/0366a9184f404115fb3c18c17cd90eebc04aaafa/test/app_web/api_test.exs#L43C13-L48

But the Good News is that tests work on localhost:

mix c
...............
Finished in 1.5 seconds (1.4s async, 0.1s sync)
15 tests, 0 failures

Randomized with seed 591967
----------------
COV    FILE                                        LINES RELEVANT   MISSED
100.0% lib/app.ex                                      9        0        0
100.0% lib/app/repo.ex                                 5        0        0
100.0% lib/app/upload.ex                             108       20        0
100.0% lib/app_web/components/layouts.ex               5        0        0
100.0% lib/app_web/controllers/api_controller.e       46       10        0
100.0% lib/app_web/controllers/api_json.ex            20        3        0
100.0% lib/app_web/controllers/page_controller.       25        5        0
100.0% lib/app_web/controllers/page_html.ex            5        0        0
100.0% lib/app_web/endpoint.ex                        48        0        0
100.0% lib/app_web/live/imgup_live.ex                 93       26        0
100.0% lib/app_web/router.ex                          30        4        0
100.0% lib/app_web/s3_upload.ex                      127       24        0
[TOTAL] 100.0%
----------------
Generating report...
Saved to: cover/

Now looking into "Part 2" on Fly.io.

nelsonic · 2023-07-05T09:58:09Z

FYI: I've renamed the two S3 Bucket environment variables:

AWS_COMPRESSED_BUCKET-> AWS_S3_BUCKET_ORIGINAL
AWS_COMPRESSED_BUCKET -> AWS_S3_BUCKET_COMPRESSED

The reason is:

Including the S3 keyword in the env var makes it clear what kind of bucket we are using. Believe it or not, I've had several people ask me this question in the past when using S3 ... 🙄 So having it clear avoids those questions. 👌
Putting the "variable" at the end of the variable name helps with scanning.

I've updated the variables in the project, CI and Fly.io.

flyctl secrets set AWS_S3_BUCKET_ORIGINAL=imgup-original -a imgup
flyctl secrets set AWS_S3_BUCKET_COMPRESSED=imgup-compressed -a imgup

Removed the "old" ones to avoid confusion:

fly secrets unset AWS_ORIGINAL_BUCKET -a imgup
fly secrets unset AWS_COMPRESSED_BUCKET -a imgup

https://fly.io/apps/imgup/secrets

FYI: the two bucket names were not in the README.md Env Var section:
https://github.com/dwyl/imgup/tree/edge-cases-%2369#2-get-your-aws-keys-and-export-as-environment-variables

So added them. ✅

…ment) ref: #80 / #69

nelsonic · 2023-07-15T05:13:17Z

api.md

+```elixir
+def upload(image) do
+    # Create `CID` from file contents so filenames are unique
+    case File.read(image.path) do


@LuchoTurtle you've shifted the logic without simplifying it.
This is worse than inlining it.
And without any logging this code is basically a black box when debugging.

Added comment on this in #86 (comment).

nelsonic

I'm not happy with writing a mock or code for an unspecified AWS S3 failure event that we cannot test for.
It's totally fine to have a generic failure event in this exceptionally unlikely event of there being an error with S3.

Generally speaking, a Software product/app that calls many external APIs in the "backend"
does not expose these details to the client/consumer.
Unless the client already knows those services are being used, e.g. Google Auth
In the case of S3 the image URL currently has S3 in the address but it definitely won't for ever ...

The last S3 outage was in 2017: https://aws.amazon.com/message/41926/
They are exceedingly rare and if we cannot test the scenario, to all intents and purposes, it doesn't exist.

In the "Mars Rover" analogy: if the uplink back to NASA HQ is down
the lander isn't going to send a messages back to NASA HQ saying the channel is broken because they already know and what channel would they use ... 🤷‍♂️

If an error occurs with S3 we just return a generic:
"Sorry uploads are not working right now, please try again later."
Or if we want to get fancy, we return a "trace ID" that allows the engineers to immediately find that request in the logs.
See: https://www.w3.org/TR/trace-context/

We can (should) log the error in our infra so that we know why it happened.
And when we eventually have a "status" page we can write a quick post explaining what the root cause is so people how how we fixed it.
But adding mocks to the project just so that we can pretend to test for this black swan event is not useful.

We don't yet have a "style guide" for our Elixir code.
But if we did the with keyword and <- (reverse arrow) notation would definitely be on the "No" list.
They make the code terse without any real benefit other than masking complexity of implementation.

    with {:ok, {file_cid, file_extension}} <- check_file_binary_and_extension(image),
         {:ok, {file_name, upload_response_body}} <-
           upload_file_to_s3(file_cid, file_extension, image) do

This is just shifting business logic into one line and requires significant time for the (human) reader to parse.
"Go do all these things and if anything fails return a bunch of errors..."
Then putting a bunch of matches for those errors:

{:error, :failure_read} -> {:error, :failure_read}
{:error, :invalid_extension_and_cid} -> {:error, :invalid_extension_and_cid}
{:error, :invalid_cid} -> {:error, :invalid_cid}
{:error, :invalid_extension} -> {:error, :invalid_extension}
{:error, :upload_fail} -> {:error, :upload_fail}

If you aren't actually doing anything with the error message/type,
then just pass it straight through with a generic "reason":

{:error, reason} -> {:error, reason}

Otherwise you are duplicating logic unnecessarily.

I don't like this code at all. Because all you have done is move the complexity elsewhere.
One of the biggest problems smart people have is they write complex code.
Code that will confuse and overwhelm a beginner.
This is fine in a close source 2-person project.
But not desirable in an Open Source project where we want others to read and contribute to the code.

lib/app_web/controllers/api_controller.ex

nelsonic · 2023-07-15T05:37:14Z

I don't want to just close this PR and waste both my own time and Lucho's time. ⏳ 💸 🔥
But I don't feel like any of this code addresses a problem that a person using the API has identified. 🤷‍♂️
Yes, we want to address potential edge cases. ✅
We want to make the API helpful to the people using it. 🙏
But this PR doesn't do that. 😕
It has zero Logging which means the engineers cannot debug errors
and returns unhelpful errors that mask the underlying issue.

nelsonic · 2023-07-15T05:49:52Z

For future reference, whenever you are tempted to put the word "and" in a function name, don't.
check_file_binary_and_extension is an instant "code smell".

api.md

…m/dwyl/imgup/pull/86/files#r1264339056

nelsonic · 2023-07-17T10:10:37Z

@LuchoTurtle I've already removed (commented out) the offending mock and added a valid test.
The remaining tests are all passing with 100% coverage.
This PR is mergeable. Assign back to me once you've had a chance to tidy the section in the README.md
Thanks. 👍

…only.

…dge-cases-#69 # Conflicts: # lib/app_web/controllers/api_controller.ex # test/app_web/api_test.exs

LuchoTurtle · 2023-07-17T11:33:37Z

I've made some changes, namely:

added logging.
added tests for invalid content types.
changed API error messages that are relevant to the person, and defaulted unlikely scenarios (such as S3 being down) to display a generic message.

I didn't change "code smells" like check_file_binary_and_extension since you want to get this merged ASAP and that would entail more time spend reviewing.
Granted, although I understand your statements about not wanting to use with statements and avoiding nested case statements that capture these edge cases, I don't know how to "simplify" the code that will, simultaneously:

log each scenario so we know what exactly went wrong.
not use nested cases without containing logic in functions

Perhaps my Elixir syntax skills are lacking but I don't know how to make the code more readable and simpler without doing these.

Assigning back to you, I've made the changes according to the feedback and commented on those that were affected.

nelsonic

Thanks @LuchoTurtle 👌
All good enhancements. ✅
Hopefully we can focus on features requested by people using the product. 🤞

LuchoTurtle · 2023-07-17T13:11:13Z

@nelsonic working on #87 because of merge conflicts and trying to remove Mock, fyi

nelsonic · 2023-07-17T13:13:22Z

Cool. Thanks.

LuchoTurtle added 5 commits June 27, 2023 15:12

fix: Pattern matching when file is read. #69

3fa6ba3

fix: Pattern matching to cover edge cases. #69

6dc3b4a

feat: Adding tests to check for CID and extension pattern matching. #69

1490d08

fix: Finishing tests. #69

317f1be

feat: Adding section to README. #69

02933e6

LuchoTurtle added enhancement New feature or enhancement of existing functionality chore a tedious but necessary task often paying technical debt in-progress An issue or pull request that is being worked on by the assigned person elixir Pull requests that update Elixir code labels Jun 28, 2023

LuchoTurtle self-assigned this Jun 28, 2023

LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Jun 28, 2023

LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Jun 28, 2023

nelsonic added this to More ToDo ThanCanEver Be Done in Nelson's List via automation Jul 1, 2023

nelsonic moved this from More ToDo ThanCanEver Be Done to Awaiting Feedback/Review in Nelson's List Jul 1, 2023

nelsonic previously approved these changes Jul 4, 2023

View reviewed changes

LuchoTurtle mentioned this pull request Jul 4, 2023

Feat: Filenames on S3 should be the cid of the content ... #62

Closed

1 task

Chore: rename AWS_S3_BUCKET environment varialble names see: #86 (com…

357c277

…ment) ref: #80 / #69

nelsonic dismissed their stale review via 357c277 July 5, 2023 10:00

nelsonic reviewed Jul 15, 2023

View reviewed changes

nelsonic requested changes Jul 15, 2023

View reviewed changes

nelsonic reviewed Jul 15, 2023

View reviewed changes

lib/app_web/controllers/api_controller.ex Outdated Show resolved Hide resolved

nelsonic added in-progress An issue or pull request that is being worked on by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Jul 15, 2023

nelsonic moved this from Delegated / External to In progress in Nelson's List Jul 15, 2023

log the error when upload_file_to_s3/3 fails #69

831d2eb

nelsonic reviewed Jul 15, 2023

View reviewed changes

api.md Outdated Show resolved Hide resolved

comment out out Mock for S3 Upload (false positive) https://github.co…

ef113ec

…m/dwyl/imgup/pull/86/files#r1264339056

LuchoTurtle assigned LuchoTurtle and unassigned nelsonic Jul 17, 2023

LuchoTurtle added 4 commits July 17, 2023 11:53

fix: Logging errors and returning relevant information to the person …

4c4a1a5

…only.

Merge branch 'edge-cases-#69' of https://github.com/dwyl/imgup into e…

37d073c

…dge-cases-#69 # Conflicts: # lib/app_web/controllers/api_controller.ex # test/app_web/api_test.exs

chore: Updating API.md document with latest changes. #69

ab7fda5

feat: Add API return error when content type is invalid. #69

40e5455

LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Jul 17, 2023

LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Jul 17, 2023

nelsonic approved these changes Jul 17, 2023

View reviewed changes

nelsonic merged commit 66a8e0f into main Jul 17, 2023
3 checks passed

Nelson's List automation moved this from In progress to Done Jul 17, 2023

nelsonic deleted the edge-cases-#69 branch July 17, 2023 13:10

LuchoTurtle mentioned this pull request Jul 17, 2023

[PR] Adding liveview version without pushing to S3 from client #87

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PR] Addressing edge cases #86

[PR] Addressing edge cases #86

LuchoTurtle commented Jun 28, 2023

LuchoTurtle commented Jun 28, 2023

nelsonic left a comment •

edited

nelsonic commented Jul 4, 2023

LuchoTurtle commented Jul 4, 2023

LuchoTurtle commented Jul 4, 2023

LuchoTurtle commented Jul 4, 2023 •

edited

nelsonic commented Jul 4, 2023

nelsonic commented Jul 4, 2023

LuchoTurtle commented Jul 4, 2023

nelsonic commented Jul 5, 2023

nelsonic commented Jul 5, 2023

nelsonic Jul 15, 2023

LuchoTurtle Jul 17, 2023

nelsonic left a comment

nelsonic commented Jul 15, 2023

nelsonic commented Jul 15, 2023

nelsonic commented Jul 17, 2023

LuchoTurtle commented Jul 17, 2023 •

edited

nelsonic left a comment

LuchoTurtle commented Jul 17, 2023

nelsonic commented Jul 17, 2023

[PR] Addressing edge cases #86

[PR] Addressing edge cases #86

Conversation

LuchoTurtle commented Jun 28, 2023

LuchoTurtle commented Jun 28, 2023

nelsonic left a comment • edited

Choose a reason for hiding this comment

nelsonic commented Jul 4, 2023

LuchoTurtle commented Jul 4, 2023

LuchoTurtle commented Jul 4, 2023

LuchoTurtle commented Jul 4, 2023 • edited

nelsonic commented Jul 4, 2023

nelsonic commented Jul 4, 2023

LuchoTurtle commented Jul 4, 2023

nelsonic commented Jul 5, 2023

nelsonic commented Jul 5, 2023

nelsonic Jul 15, 2023

Choose a reason for hiding this comment

LuchoTurtle Jul 17, 2023

Choose a reason for hiding this comment

nelsonic left a comment

Choose a reason for hiding this comment

nelsonic commented Jul 15, 2023

nelsonic commented Jul 15, 2023

nelsonic commented Jul 17, 2023

LuchoTurtle commented Jul 17, 2023 • edited

nelsonic left a comment

Choose a reason for hiding this comment

LuchoTurtle commented Jul 17, 2023

nelsonic commented Jul 17, 2023

nelsonic left a comment •

edited

LuchoTurtle commented Jul 4, 2023 •

edited

LuchoTurtle commented Jul 17, 2023 •

edited