Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR] Fix deploying env vars issue #95

Merged
merged 3 commits into from
Jul 11, 2023
Merged

[PR] Fix deploying env vars issue #95

merged 3 commits into from
Jul 11, 2023

Conversation

LuchoTurtle
Copy link
Member

closes #88

This should fix the deploying issues we've been having. The prod config file was incomplete. Because config should be used in a more generalized way and is valid for both test and prod environments, the full configuration of ex_aws is found there.

https://elixirforum.com/t/when-does-runtime-exs-make-more-sense/34812

@LuchoTurtle LuchoTurtle added bug Suspected or confirmed bug (defect) in the code priority-1 Highest priority issue. This is costing us money every minute that passes. chore a tedious but necessary task often paying technical debt in-progress An issue or pull request that is being worked on by the assigned person BLOCKED :fire: Core team's HIGHEST priority, blocking critical work labels Jul 11, 2023
@LuchoTurtle LuchoTurtle self-assigned this Jul 11, 2023
@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Jul 11, 2023
@LuchoTurtle
Copy link
Member Author

@nelsonic please review this and merge when you can. It should make merging the other two PRs possible and it's what's blocking them.

nelsonic
nelsonic approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuchoTurtle looks good. 👍

@nelsonic nelsonic merged commit f971af3 into main Jul 11, 2023
1 check passed
@LuchoTurtle LuchoTurtle deleted the deploy-vars_fix#88 branch July 11, 2023 09:16
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels
BLOCKED :fire: Core team's HIGHEST priority, blocking critical work bug Suspected or confirmed bug (defect) in the code chore a tedious but necessary task often paying technical debt in-progress An issue or pull request that is being worked on by the assigned person priority-1 Highest priority issue. This is costing us money every minute that passes.
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Couldn't upload files to S3. Open an issue on Github and contact the repo owner.
2 participants
@LuchoTurtle @nelsonic