Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Readme to document Future, async and await #10

Merged
merged 3 commits into from
Jan 22, 2020

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Jan 21, 2020

ref: #9

Add an asynchronous section, to explain how to use the Future class and the async/await and then keywords

Copy link
Collaborator

@miguelmartins17 miguelmartins17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab In my opinion and a very interesting piece of information that should certainly be added.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
}
```

To test this code you can copy/paste it and run it on dartpad: https://dartpad.dev/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab great additions. 🥇
I've made a few minor suggestions. ✍️
Feel free to accept/reject .then we can merge. 😉

Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻 thanks for another set of great additions @SimonLab, learning a lot from reviewing these PRs!

SimonLab and others added 2 commits January 21, 2020 21:47
Thanks for fixing the `futur` typo!

Co-Authored-By: Nelson <nelson+github@dwyl.io>
Update Future states description (uncompleted, completed success, completed error)

Co-Authored-By: Nelson <nelson+github@dwyl.io>
@SimonLab
Copy link
Member Author

Thanks for the reviews! @nelsonic I've merged your suggestions and it should be ready to merge now 👍

@SimonLab SimonLab assigned nelsonic and unassigned SimonLab Jan 22, 2020
@nelsonic
Copy link
Member

@SimonLab Thanks for accepting the suggestions.
Merging. 👍

@nelsonic nelsonic merged commit da72f0b into master Jan 22, 2020
@nelsonic nelsonic deleted the future-async-await-#9 branch January 22, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants