Change global Istanbul use to local #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quote> Running directly will not work as we only install it locally. This change should ensure the command works as expected. quote> Relates dwyl#79
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 33 33
=====================================
Hits 33 33Continue to review full report at Codecov.
|
nelsonic
approved these changes
Feb 27, 2017
There was a problem hiding this comment.
@oliverjam thanks for fixing this. (we always prefer relative/local module usage)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
istanbul cover test.jsdirectly will not work as we only install it locally. This change should ensure the command works as expected.Relates #79