Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme to fix a bunch of issues #272

Merged
merged 5 commits into from
Aug 19, 2018
Merged

update readme to fix a bunch of issues #272

merged 5 commits into from
Aug 19, 2018

Conversation

mckennapsean
Copy link
Collaborator

Fixes #151, #201, #239, #268, #270

Note: #271, I am not updating all the translated readmes. I'll leave my opinion on that issue, but I do not know either language to provide contributions there. I did add one image on the verification step, which I could put in both language's readme files, otherwise I changed what I could find.

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mckennapsean looks great. thanks for fixing! 🎉

@mckennapsean mckennapsean merged commit 133ceb9 into master Aug 19, 2018
@mckennapsean mckennapsean deleted the update-readme branch January 7, 2019 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants