Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: View Archived items #119

Closed
nelsonic opened this issue Aug 8, 2022 · 5 comments
Closed

Feat: View Archived items #119

nelsonic opened this issue Aug 8, 2022 · 5 comments
Assignees
@SimonLab
Labels
awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt discuss Share your constructive thoughts on how to make progress with this issue enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T4h Time Estimate 4 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies user-feedback Feedback from people using the App
Projects
Nelson's List Simon's list

Comments

@nelsonic
Copy link
Member

nelsonic commented Aug 8, 2022

Story

As a person using the MVP to track time taken on a task (item),
I want to see the completed (archived) items,
So that I can see the history of items I've worked on (and completed)

At present when an item is archived it disappears from the UI and there is no way to view it.
This was both deliberate to reduce UI clutter and an obvious oversight
because if people cannot see their archived items they don't have trust in the system
to use it as their "second brain".

@SimonLab want to pair on this or pick it up solo?
Very similar to https://github.com/dwyl/phoenix-liveview-todo-list-tutorial#9-footer-navigation
@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! technical A technical issue that requires understanding of the code, infrastructure or dependencies T4h Time Estimate 4 Hours priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished user-feedback Feedback from people using the App discuss Share your constructive thoughts on how to make progress with this issue chore a tedious but necessary task often paying technical debt labels Aug 8, 2022
@nelsonic nelsonic added this to More ToDo ThanCanEver Be Done in Nelson's List via automation Aug 8, 2022
@SimonLab SimonLab self-assigned this Aug 9, 2022
@SimonLab SimonLab added this to To do in Simon's list via automation Aug 9, 2022
@SimonLab
Copy link
Member

SimonLab commented Aug 9, 2022

I'm happy to have a go at this today, once I've merged your PR.
I think we can use LiveView to toggle between current/archived items.
I'm not sure yet where we should display the links, footer, navbar but I'll have a try.

@SimonLab SimonLab moved this from To do to In progress in Simon's list Aug 9, 2022
This was referenced Aug 9, 2022
Merged
Closed
@SimonLab SimonLab added the in-review Issue or pull request that is currently being reviewed by the assigned person label Aug 10, 2022
SimonLab added a commit that referenced this issue Aug 10, 2022
@SimonLab
Filter items by status
e33c930 
- Display footer with All, Active, Done and Archived links
- Filter items by status using LiveView

ref: #119
@SimonLab SimonLab mentioned this issue Aug 10, 2022
Merged
SimonLab added a commit that referenced this issue Aug 10, 2022
@SimonLab
Filter items by status
df30f1f 
- Display footer with All, Active, Done and Archived links
- Filter items by status using LiveView

ref: #119
@SimonLab
Copy link
Member

Feature implemented with #125
It allows to filter items by "all", "active", "done" and "archived"
I need to finish the PR by adding some css and updating the BUILDIT file

@SimonLab SimonLab moved this from In progress to Awaiting Feedback/Review in Simon's list Aug 10, 2022
@SimonLab SimonLab added awaiting-review An issue or pull request that needs to be reviewed and removed in-review Issue or pull request that is currently being reviewed by the assigned person labels Aug 10, 2022
@SimonLab
Copy link
Member

#125 is now merged and the items are filtered by status.
One small UI enhancement I want to add is to underline the selected filter to make it more obvious which items are currently displayed

@nelsonic
Copy link
Member Author

@SimonLab please see new issue: #126 💭

@nelsonic
Copy link
Member Author

Current UX:
only-show-footer-nav-when-items-1

Nelson's List automation moved this from More ToDo ThanCanEver Be Done to Done Aug 14, 2022
@SimonLab SimonLab moved this from Awaiting Feedback/Review to Done in Simon's list Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonLab SimonLab

Labels
awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt discuss Share your constructive thoughts on how to make progress with this issue enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T4h Time Estimate 4 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies user-feedback Feedback from people using the App
Projects
Nelson's List
  
Done
Simon's list
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nelsonic @SimonLab