Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Capture list_cid URL parameter in LiveView mount/3 ... #425

Closed
1 task done
Tracked by #165
nelsonic opened this issue Sep 15, 2023 · 3 comments
Closed
1 task done
Tracked by #165

Feat: Capture list_cid URL parameter in LiveView mount/3 ... #425

nelsonic opened this issue Sep 15, 2023 · 3 comments
Assignees
@nelsonic
Labels
elixir Pull requests that update Elixir code enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T25m Time Estimate 25 Minutes technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
Nelson's List

Comments

@nelsonic
Copy link
Member

nelsonic commented Sep 15, 2023 •
edited
Loading

At present our mount/3 function is ignoring the params:

mvp/lib/app_web/live/app_live.ex

Line 18 in b8aee0e

def mount(_params, _session, socket) do

If we check for a list_cid parameter in the URL it will allow us to display the contents of the list.

Ref: https://elixirforum.com/t/handling-and-retrieving-query-parameters-in-live-view/49006
|> https://hexdocs.pm/phoenix_live_view/Phoenix.LiveView.html#c:mount/3

Todo
@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality T25m Time Estimate 25 Minutes technical A technical issue that requires understanding of the code, infrastructure or dependencies priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished elixir Pull requests that update Elixir code labels Sep 15, 2023
@nelsonic nelsonic self-assigned this Sep 15, 2023
@nelsonic nelsonic added this to More ToDo ThanCanEver Be Done in Nelson's List via automation Sep 15, 2023
@nelsonic nelsonic mentioned this issue Sep 16, 2023
Merged
10 tasks
@nelsonic nelsonic moved this from More ToDo ThanCanEver Be Done to In progress in Nelson's List Nov 1, 2023
@nelsonic nelsonic added the in-progress An issue or pull request that is being worked on by the assigned person label Nov 1, 2023
@nelsonic
Copy link
Member Author

nelsonic commented Nov 1, 2023

This is the last hurdle/requirement to ship #165 so I'm taking a quick look at it now. 🧑‍💻 ⏳ 🤞

@nelsonic
Copy link
Member Author

nelsonic commented Nov 1, 2023

I've got this working. Will be uploading a video demo shortly. But just spotted a bug I want to fix.

nelsonic added a commit that referenced this issue Nov 1, 2023
@nelsonic
add item to custom list #425 for #165
a58edec
@nelsonic
Copy link
Member Author

nelsonic commented Nov 1, 2023

Included in: #165 (comment)

@nelsonic nelsonic closed this as completed Nov 1, 2023
Nelson's List automation moved this from In progress to Done Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

Labels
elixir Pull requests that update Elixir code enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T25m Time Estimate 25 Minutes technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
Nelson's List
  
Done
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic