PR: `Lists` #165

SimonLab · 2022-10-05T15:16:23Z

This PR creates the list interface for managing lists and adding/removing/moving items.
Includes:

codecov · 2022-10-05T20:12:34Z

Codecov Report

Merging #165 (6aae78a) into main (a0e1594) will decrease coverage by 0.31%.
Report is 60 commits behind head on main.
The diff coverage is 97.33%.

@@             Coverage Diff             @@
##              main     #165      +/-   ##
===========================================
- Coverage   100.00%   99.69%   -0.31%     
===========================================
  Files           22       26       +4     
  Lines          599      659      +60     
===========================================
+ Hits           599      657      +58     
- Misses           0        2       +2

Files	Coverage Δ
lib/app/item.ex	`100.00% <100.00%> (ø)`
lib/app/list.ex	`100.00% <100.00%> (ø)`
lib/app_web/controllers/list_controller.ex	`100.00% <100.00%> (ø)`
lib/app_web/controllers/tag_controller.ex	`100.00% <100.00%> (ø)`
lib/app_web/live/components/nav.ex	`100.00% <100.00%> (ø)`
lib/app_web/live/stats_live.ex	`100.00% <ø> (ø)`
lib/app_web/router.ex	`100.00% <ø> (ø)`
lib/app_web/views/list_view.ex	`100.00% <100.00%> (ø)`
lib/app_web/views/nav_view.ex	`100.00% <100.00%> (ø)`
lib/app_web/live/app_live.ex	`98.75% <91.30%> (-1.25%)`	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Create the lists table

Create list controller to add and edit lists

Create item controller to link items to lists

- Add/Remove list linked to an item - Display lists as badges on main page

lib/app/item.ex

Check if person exist before insert

Add schemas and controllers tests

SimonLab · 2022-10-08T14:34:19Z

Displaying the item's lists under the tags:

- Add test for item controller managing lists - Fix #168

…oller_test.exs

nelsonic · 2023-09-15T03:58:13Z

the "all" list is not editable as discussed in: #400 (comment)

chore: Making variables "snake_case" in drag and drop code

… allow displaying lists

nelsonic · 2023-11-01T17:26:29Z

Custom Lists:

nelsonic

Nice. 😍 Thanks @SimonLab 👌

SimonLab added the in-progress An issue or pull request that is being worked on by the assigned person label Oct 5, 2022

SimonLab added this to To do in Simon's list via automation Oct 5, 2022

SimonLab self-assigned this Oct 5, 2022

SimonLab moved this from To do to In progress in Simon's list Oct 5, 2022

SimonLab temporarily deployed to dwylauth October 5, 2022 20:08 Inactive

SimonLab temporarily deployed to dwylauth October 5, 2022 21:17 Inactive

SimonLab added 3 commits October 5, 2022 22:37

Create lists table and list schema

498a231

Create the lists table

Add list controller

13e3c6b

Create list controller to add and edit lists

Add item endpoint

3c3e83c

Create item controller to link items to lists

SimonLab force-pushed the items-list branch from 3772cf3 to 3c3e83c Compare October 5, 2022 21:39

SimonLab temporarily deployed to dwylauth October 5, 2022 21:39 Inactive

Display lists under tags

ffe8d64

- Add/Remove list linked to an item - Display lists as badges on main page

SimonLab temporarily deployed to dwylauth October 7, 2022 10:55 Inactive

nelsonic reviewed Oct 7, 2022

View reviewed changes

lib/app/item.ex Outdated Show resolved Hide resolved

Insert or get person

74e73ab

Check if person exist before insert

SimonLab temporarily deployed to dwylauth October 7, 2022 19:56 Inactive

Add tests for lists

a3269b7

Add schemas and controllers tests

SimonLab temporarily deployed to dwylauth October 7, 2022 21:44 Inactive

SimonLab temporarily deployed to dwylauth October 8, 2022 14:33 Inactive

SimonLab marked this pull request as ready for review October 8, 2022 14:40

Add item controller test for lists

68f5562

- Add test for item controller managing lists - Fix #168

SimonLab force-pushed the items-list branch from 6e7f885 to 68f5562 Compare October 8, 2022 14:45

SimonLab temporarily deployed to dwylauth October 8, 2022 14:45 Inactive

SimonLab mentioned this pull request Oct 8, 2022

Resetting database doen't allow people to login #168

Closed

1 task

SimonLab assigned nelsonic and unassigned SimonLab Oct 8, 2022

SimonLab added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Oct 8, 2022

nelsonic added 3 commits September 15, 2023 02:23

#400 tidy styling of /lists page as per: #400 (comment)

18a776c

#400 fix test assertion (text) in test/app_web/controllers/list_contr…

fb6a393

…oller_test.exs

add title_case/1 function for list.name

10a2a6a

This was referenced Sep 15, 2023

Feat: items_with_timers/1 -> items_with_timers/2 (list_cid) #423

Closed

Feat: Add Lists to Main Menu #424

Closed

chore: Making variables "snake_case" in drag and drop code #419

Merged

nelsonic and others added 4 commits September 16, 2023 09:53

Merge pull request #419 from dwyl/variable_consistency#416

d70ea74

chore: Making variables "snake_case" in drag and drop code

#423 update items_with_timers/1 to accept list_cid as second param to…

81c7227

… allow displaying lists

#423 mix format ... tidies items_with_timers/2 code & tests

15af0f1

#427 create move_item_from_lista_to_listb/4 & test

dd59426

nelsonic mentioned this pull request Sep 16, 2023

Feat: move_item_from_lista_to_listb/4 function for moving items between lists #427

Closed

3 tasks

nelsonic and others added 7 commits October 29, 2023 06:11

split nav from root.html to separate component for #424 #165

2d12ffe

render nav template in tag/index.html #424 #165

284a496

render list.name + list_url in nav menu #424 #165

31df47e

add lists to stats_live.ex so nav can render on stats page #145 #424

8a785e3

differentiate custom lists from other links in main menu #145 #424

cbd558d

Merge branch 'main' into items-list

f182747

mix format 🙄 #165

7f7c78b

nelsonic mentioned this pull request Nov 1, 2023

Feat: Capture list_cid URL parameter in LiveView mount/3 ... #425

Closed

1 task

nelsonic added the awaiting-review An issue or pull request that needs to be reviewed label Nov 1, 2023

nelsonic moved this from Backlog (Prioritized) to Awaiting Feedback/Review in Nelson's List Nov 1, 2023

nelsonic added 2 commits November 1, 2023 17:27

add item to custom list #425 for #165

a58edec

remove dbg() #165

6aae78a

nelsonic approved these changes Nov 1, 2023

View reviewed changes

nelsonic merged commit 07c41ce into main Nov 1, 2023
1 check passed

Nelson's List automation moved this from Awaiting Feedback/Review to Done Nov 1, 2023

nelsonic deleted the items-list branch November 1, 2023 17:32

LuchoTurtle mentioned this pull request Nov 1, 2023

feat: Lists enhancements #439

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: `Lists` #165

PR: `Lists` #165

SimonLab commented Oct 5, 2022 •

edited by nelsonic

codecov bot commented Oct 5, 2022 •

edited

SimonLab commented Oct 8, 2022

nelsonic commented Sep 15, 2023

nelsonic commented Nov 1, 2023

nelsonic left a comment

PR: Lists #165

PR: Lists #165

Conversation

SimonLab commented Oct 5, 2022 • edited by nelsonic

codecov bot commented Oct 5, 2022 • edited

Codecov Report

SimonLab commented Oct 8, 2022

nelsonic commented Sep 15, 2023

nelsonic commented Nov 1, 2023

nelsonic left a comment

Choose a reason for hiding this comment

PR: `Lists` #165

PR: `Lists` #165

SimonLab commented Oct 5, 2022 •

edited by nelsonic

codecov bot commented Oct 5, 2022 •

edited