Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add auth_plug to Phoenix Chat Example so people can authenticate 🔐 #54

Closed
5 of 6 tasks
nelsonic opened this issue Sep 11, 2021 · 5 comments
Closed
5 of 6 tasks

Feat: Add auth_plug to Phoenix Chat Example so people can authenticate 🔐 #54

nelsonic opened this issue Sep 11, 2021 · 5 comments
Assignees
@LuchoTurtle
Labels
enhancement New feature or request help wanted Extra attention is needed priority-2 T4h
Projects
Nelson's List

Comments

@nelsonic
Copy link
Member

nelsonic commented Sep 11, 2021 •
edited
Loading

This tutorial is currently already quite popular. 🤩 🎉
We can take it to the next level by adding auth via auth_plug using ONE Environment Variable™! 🚀

Story

As a person learning Elixir/Phoenix 🌱
I need a fully featured example including auth 🔐
So that I can learn the Tech Stack as fast as possible and contribute in the team. 🙌

@LuchoTurtle hopefully you can identify with this story. 🤞

Todo

  • Create a new markdown file called auth.md and link to it from the main README.md
  • Document each step in the setup process for adding authentication to this Chat App.
  • Add auth_plug to this project, see: https://github.com/dwyl/auth_plug_example#how
    • Along the way, if you get stuck, please open issues! 🙏

Our objective is to make all our docs "standalone"; i.e. anyone can pick up and understand exactly what is going on without hitting any hurdles. We acknowledge that we aren't there yet: dwyl/auth#153 (comment) so we need lots of help to get to the point where auth has superb documentation.

Very happy to pair on this if you want an idea of my workflow.

Hopefully this is a fun challenge that will help you to learn a bit of the Tech Stack 🤞
and make it a lot easier for the next people joining the team. 😉

image
@nelsonic nelsonic mentioned this issue Sep 11, 2021
Closed
5 tasks
@nelsonic nelsonic changed the title : add to the example so we get "" people. Add auth_plug to the example so people can authenticate Sep 11, 2021
@nelsonic nelsonic added enhancement New feature or request help wanted Extra attention is needed priority-3 T4h labels Sep 11, 2021
@nelsonic nelsonic added this to More ToDo ThanCanEver Be Done in Nelson's List via automation Sep 11, 2021
@ajmeese7 ajmeese7 self-assigned this Oct 14, 2021
nelsonic added a commit that referenced this issue Oct 15, 2021
@nelsonic
temporarily comment out authorized?/1 function as its just returning …
f12eaeb 
…"true". See: #54 for auth
@nelsonic nelsonic mentioned this issue Oct 18, 2021
Open
SimonLab added a commit that referenced this issue Oct 19, 2021
@SimonLab
remove asset buildpack #54
83392bc
@nelsonic nelsonic assigned LuchoTurtle and unassigned ajmeese7 Oct 12, 2022
@nelsonic nelsonic changed the title Add auth_plug to the example so people can authenticate Feat: Add auth_plug to Phoenix Chat Example so people can authenticate 🔐 Oct 12, 2022
@nelsonic nelsonic mentioned this issue Oct 12, 2022
Closed
@nelsonic nelsonic pinned this issue Oct 12, 2022
@LuchoTurtle LuchoTurtle mentioned this issue Oct 12, 2022
Merged
@LuchoTurtle LuchoTurtle mentioned this issue Nov 14, 2022
Merged
3 tasks
@nelsonic nelsonic mentioned this issue Nov 14, 2022
Closed
10 tasks
nelsonic added a commit that referenced this issue Nov 14, 2022
@nelsonic
comment out unused code until tests are written for it ... #54
d4fe4fc
@nelsonic
Copy link
Member Author

Ref: https://github.com/dwyl/phoenix-liveview-chat-example#12-authentication

@nelsonic
Copy link
Member Author

https://authdemo.fly.dev/apps

nelsonic added a commit that referenced this issue Nov 16, 2022
@nelsonic
re-number sections in auth.md #54
23d0dfb
nelsonic added a commit that referenced this issue Nov 17, 2022
@nelsonic
create auth_controller.ex for #54
1b18ff3
nelsonic added a commit that referenced this issue Nov 17, 2022
@nelsonic
create test/chat_web/controllers/auth_controller_test.exs for #54
a4e0d7f
nelsonic added a commit that referenced this issue Nov 17, 2022
@nelsonic
reference auth.md from README.md #54
4cea168
nelsonic added a commit that referenced this issue Nov 17, 2022
@nelsonic
add AUTH_API_KEY: 2PzB7PPnpuLsbWmWtXpGyI+kfSQSQ1zUW2Atz/+8PdZuSEJzHgz…
db58d44 
…GnJWV35nTKRwx/authdemo.fly.dev to ci.yml #54
nelsonic added a commit that referenced this issue Nov 17, 2022
@nelsonic
AUTH_API_KEY: ${{ secrets.AUTH_API_KEY }} #54
b9b7273
@nelsonic
Copy link
Member Author

@LuchoTurtle PR: #120 should be good for you to continue/finish. 🙏

nelsonic added a commit that referenced this issue Nov 30, 2022
@nelsonic
delete lib/chat_web/templates/page/auth.html.eex as no longer needed …
7d74aa5 
…for #54
nelsonic added a commit that referenced this issue Nov 30, 2022
@nelsonic
simplify test/chat_web/controllers/auth_controller_test.exs for #54
c4d860f
nelsonic added a commit that referenced this issue Nov 30, 2022
@nelsonic
add "Update UI" section to auth.md #54
cf4959c
nelsonic added a commit that referenced this issue Dec 1, 2022
@nelsonic
significantly simplify app.js #54 / #121
458a722
nelsonic added a commit that referenced this issue Dec 1, 2022
@nelsonic
update Gifs for Tailwind CSS #121 and auth #54
9ce59c0
@nelsonic
Copy link
Member Author

nelsonic commented Dec 1, 2022

Done! #120 🎉

@nelsonic nelsonic closed this as completed Dec 1, 2022
Nelson's List automation moved this from More ToDo ThanCanEver Be Done to Done Dec 1, 2022
@nelsonic nelsonic unpinned this issue Dec 2, 2022
@nelsonic
Copy link
Member Author

nelsonic commented Dec 2, 2022

https://github.com/dwyl/phoenix-chat-example/blob/main/auth.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuchoTurtle LuchoTurtle

Labels
enhancement New feature or request help wanted Extra attention is needed priority-2 T4h
Projects
Nelson's List
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nelsonic @LuchoTurtle @ajmeese7