Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Phoenix v1.5.3 and LiveView v0.13.2 #17

Closed
nelsonic opened this issue May 7, 2020 · 7 comments
Closed

Update to Phoenix v1.5.3 and LiveView v0.13.2 #17

nelsonic opened this issue May 7, 2020 · 7 comments
Assignees
Projects

Comments

@nelsonic
Copy link
Member

nelsonic commented May 7, 2020

With the release of Phoenix v1.5.3 and LiveView v0.13.2 we need to revisit this tutorial and update.

I think we could tackle this update before dwyl/phoenix-chat-example#38 as it's simpler, but equally we can do it after. 💭

This is relevant to our Email https://github.com/dwyl/email project which uses LiveView.

@nelsonic nelsonic added enhancement New feature or request T2h technical labels May 7, 2020
@SimonLab
Copy link
Member

SimonLab commented May 7, 2020

See the upgrade guide: https://gist.github.com/chrismccord/e53e79ef8b34adf5d8122a47db44d22f

If you need to first update erlang and elixir using asdf:

  • asdf update to update asdf itself
  • asdf plugin list to make sure you have erlang and elixir plugins
  • asdf plugin update erlang to update the erlang plugin (repeat for elixir)
  • asdf install erlang latest to install the latest erlang version
  • asdf global erlang <version> to set the default version of erlang
  • asdf list erlang to see the list of installed versions

@nelsonic
Copy link
Member Author

nelsonic commented May 8, 2020

@SimonLab seems like it's worth adding an intro to asdf somewhere.
e.g: https://github.com/dwyl/dev-setup or https://github.com/dwyl/learn-elixir ?

If people don't have any prior experience with the tool we are introducing them to something they don't need for the tutorial which creates a barrier to entry. Not saying asdf is not a good tool, just that it's probably not necessary for this tutorial. But it's totally legit in the toolbelt of an experienced developer. 👍

@nelsonic
Copy link
Member Author

@nelsonic nelsonic changed the title Update to Phoenix v1.5.1 and LiveView v0.12.1 Update to Phoenix v1.5.1 and LiveView v0.13 May 24, 2020
@nelsonic nelsonic added this to To do in dwyl app via automation May 28, 2020
@nelsonic nelsonic changed the title Update to Phoenix v1.5.1 and LiveView v0.13 Update to Phoenix v1.5.3 and LiveView v0.13 May 28, 2020
@nelsonic nelsonic changed the title Update to Phoenix v1.5.3 and LiveView v0.13 Update to Phoenix v1.5.3 and LiveView v0.13.2 May 28, 2020
@nelsonic nelsonic moved this from To do to In progress in dwyl app May 31, 2020
@nelsonic nelsonic self-assigned this May 31, 2020
nelsonic added a commit that referenced this issue May 31, 2020
nelsonic added a commit that referenced this issue May 31, 2020
nelsonic added a commit that referenced this issue Jun 1, 2020
@nelsonic nelsonic assigned SimonLab and unassigned nelsonic Jun 1, 2020
@nelsonic nelsonic moved this from In progress to Awaiting review in dwyl app Jun 1, 2020
@nelsonic
Copy link
Member Author

nelsonic commented Jun 1, 2020

PR: #18 🙌

@BigTom
Copy link
Contributor

BigTom commented Jun 3, 2020

End user here:

Branch seems to work fine for me (master ran but counter did not work). If that helps?

  • Running on macos catalina
  • Elixir 1.10.3 (compiled with Erlang/OTP 22)
  • Phoenix v1.5.1
  • node v14.0.0

@nelsonic
Copy link
Member Author

nelsonic commented Jun 3, 2020

@BigTom thanks for confirming. 🙌

SimonLab added a commit that referenced this issue Jun 3, 2020
…-0.13.2-issue#17

PR: Update to Phoenix 1.5.3 and LiveView 0.13.2 issue #17
@nelsonic
Copy link
Member Author

nelsonic commented Jun 5, 2020

Update PR #18 reviewed and merged by @SimonLab

@nelsonic nelsonic closed this as completed Jun 5, 2020
dwyl app automation moved this from Awaiting review to Done Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
dwyl app
  
Done
Development

No branches or pull requests

3 participants