-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Update to Phoenix 1.5.3 and LiveView 0.13.2 issue #17 #18
PR: Update to Phoenix 1.5.3 and LiveView 0.13.2 issue #17 #18
Conversation
… hooray for "--live" flag in mix phx.new! #17
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 3 +1
Lines 8 12 +4
=========================================
+ Hits 8 12 +4
Continue to review full report at Codecov.
|
Build failing due to diverged dependencies:
https://travis-ci.com/github/dwyl/phoenix-liveview-counter-tutorial/builds/168954882#L263 |
…f github.com:dwyl/phoenix-liveview-counter-tutorial into Update-to-Phoenix-1.5.3-and-LiveViev-0.13.2-issue#17
This PR is only big because I recreated the App from scratch so there's a bunch of Phoenix boilerplate and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small suggestions otherwise looks good 👍
Co-authored-by: Simon <simon.labondance@gmail.com>
Co-authored-by: Simon <simon.labondance@gmail.com>
@SimonLab thanks for fixing those two issues. 👍 |
@SimonLab thanks! 🙌 |
As the title of the PR suggests this Pull Requests contains:
README.md
to reflect new (simplified) setup process. 📝