Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update to Phoenix 1.5.3 and LiveView 0.13.2 issue #17 #18

Merged
merged 22 commits into from Jun 3, 2020

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented May 31, 2020

As the title of the PR suggests this Pull Requests contains:

@nelsonic nelsonic added enhancement New feature or request T2h in-progress labels May 31, 2020
@nelsonic nelsonic self-assigned this May 31, 2020
@nelsonic nelsonic added this to In progress in dwyl app May 31, 2020
@codecov
Copy link

codecov bot commented May 31, 2020

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         3    +1     
  Lines            8        12    +4     
=========================================
+ Hits             8        12    +4     
Impacted Files Coverage Δ
lib/live_view_counter_web/live/counter.ex 100.00% <100.00%> (ø)
lib/live_view_counter_web/telemetry.ex 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0edf6e4...d3fc0c5. Read the comment docs.

@nelsonic
Copy link
Member Author

Build failing due to diverged dependencies:

Dependencies have diverged:
* plug (Hex package)
  the dependency plug 1.9.0
  > In deps/plug_cowboy/mix.exs:
    {:plug, "~> 1.7", [env: :prod, hex: "plug", repo: "hexpm", optional: false]}
  does not match the requirement specified
  > In deps/phoenix/mix.exs:
    {:plug, "~> 1.10", [env: :prod, hex: "plug", repo: "hexpm", optional: false]}
  Ensure they match or specify one of the above in your deps and set "override: true"
* plug_cowboy (Hex package)
  the dependency plug_cowboy 2.1.2
  > In mix.exs:
    {:plug_cowboy, "~> 2.0", [env: :prod, repo: "hexpm", hex: "plug_cowboy"]}
  does not match the requirement specified
  > In deps/phoenix/mix.exs:
    {:plug_cowboy, "~> 1.0 or ~> 2.2", 
  [env: :prod, hex: "plug_cowboy", repo: "hexpm", optional: true]}
  Ensure they match or specify one of the above in your deps and set "override: true"
** (Mix) Can't continue due to errors on dependencies
The command "mix deps.get" failed and exited with 1 during .
Your build has been stopped.

https://travis-ci.com/github/dwyl/phoenix-liveview-counter-tutorial/builds/168954882#L263
image

@nelsonic nelsonic requested a review from SimonLab June 1, 2020 00:08
@nelsonic
Copy link
Member Author

nelsonic commented Jun 1, 2020

This PR is only big because I recreated the App from scratch so there's a bunch of Phoenix boilerplate and package-lock.json 🙄
In actual fact the README.md was significantly reduced! That's a great thing because the tutorial is streamlined and more beginner friendly. 🎉

@nelsonic nelsonic moved this from In progress to Awaiting review in dwyl app Jun 1, 2020
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small suggestions otherwise looks good 👍

nelsonic and others added 2 commits June 3, 2020 13:22
Co-authored-by: Simon <simon.labondance@gmail.com>
Co-authored-by: Simon <simon.labondance@gmail.com>
@nelsonic
Copy link
Member Author

nelsonic commented Jun 3, 2020

@SimonLab thanks for fixing those two issues. 👍

@SimonLab SimonLab merged commit 083e393 into master Jun 3, 2020
dwyl app automation moved this from Awaiting review to Done Jun 3, 2020
@SimonLab SimonLab deleted the Update-to-Phoenix-1.5.3-and-LiveViev-0.13.2-issue#17 branch June 3, 2020 12:42
@nelsonic
Copy link
Member Author

nelsonic commented Jun 3, 2020

@SimonLab thanks! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in-review T2h
Projects
dwyl app
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants