Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/Expand What Section of README.md issue #9 #13

Merged
merged 28 commits into from
Nov 11, 2019
Merged

Update/Expand What Section of README.md issue #9 #13

merged 28 commits into from
Nov 11, 2019

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Nov 4, 2019 •
edited
Loading

This Pull Request Addresses the question raised by @Cleop in issue #9 💭

I feel these docs are more readable now.
@iteles Please review and give feedback if possible.

@nelsonic nelsonic added the in-progress An issue or pull request that is being worked on by the assigned person label Nov 4, 2019
@nelsonic nelsonic self-assigned this Nov 4, 2019
@nelsonic nelsonic added the T4h Time Estimate 4 Hours label Nov 5, 2019
@nelsonic nelsonic mentioned this pull request Nov 9, 2019
Open
6 tasks
@nelsonic nelsonic added awaiting-review An issue or pull request that needs to be reviewed and removed T4h Time Estimate 4 Hours in-progress An issue or pull request that is being worked on by the assigned person labels Nov 9, 2019
@nelsonic nelsonic requested a review from iteles November 9, 2019 21:44
@nelsonic nelsonic assigned iteles and unassigned nelsonic Nov 9, 2019
@nelsonic nelsonic marked this pull request as ready for review November 9, 2019 21:44
@nelsonic
Copy link
Member Author

nelsonic commented Nov 9, 2019

@iteles if/when you have time, please review and give any feedback. Thanks. 📥

@nelsonic
move "Why other companies dont open source their product map?" questi…
7202898 
…on/answer to end of README.md as it breaks the flow #9
@iteles iteles added in-review Issue or pull request that is currently being reviewed by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Nov 10, 2019
SimonLab
SimonLab reviewed Nov 11, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
SimonLab
SimonLab reviewed Nov 11, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
SimonLab
SimonLab reviewed Nov 11, 2019
View reviewed changes
README.md

And finally for the _third_ step, ***Complete***,
we will build a simple checklist system.
See: [`checklists.md`](https://github.com/dwyl/product-roadmap/blob/master/checklists.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed a few typos on the checklist document, I'll create a new PR to fix them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab yes, please do fix when you have time. thanks. 👍

nelsonic and others added 3 commits November 11, 2019 11:49
@nelsonic @SimonLab
fix typo palintext > plaintext https://youtu.be/psitOvKq6X8
074b7b2 
Co-Authored-By: Simon <labdevsimon@gmail.com>
@nelsonic @SimonLab
Inês prefers bullet points to *not* have a full stop, so remove.
c8c96b9 
Co-Authored-By: Simon <labdevsimon@gmail.com>
@nelsonic @SimonLab
update link to "categorise" issue in light of moving to App repo.
ea191b8 
Co-Authored-By: Simon <labdevsimon@gmail.com>
SimonLab
SimonLab reviewed Nov 11, 2019
View reviewed changes
README.md Outdated



### USP: What is _different_ about the @dwyl App?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Sub title not displayed correctly. Looking why it's broken.

Also the USP meaning wasn't obvious to me and had too google it. We can write it down fully (Unique Selling Point/Proposition) or link it to the wikipedia page: https://en.wikipedia.org/wiki/Unique_selling_proposition

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab please edit it to help clarify it for others. thanks. 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just saw the link to the Wikipedia page just under.

SimonLab
SimonLab reviewed Nov 11, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
SimonLab
SimonLab reviewed Nov 11, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
SimonLab
SimonLab reviewed Nov 11, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
SimonLab
SimonLab reviewed Nov 11, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@SimonLab
Copy link
Member

As you've seen ⬆️ I've added a few suggestions to fix some typos.

I'm not sure yet about the USP title yet but hopefully it will be displayed properly.
The other thing I've noticed is the link to the "work hard every waking hour" youtube video is not working anymore:
image

We can either remove the link or try to find a new link to the video.

Otherwise looks good 👍

SimonLab
SimonLab reviewed Nov 11, 2019
View reviewed changes
capture.md Outdated Show resolved Hide resolved
SimonLab
SimonLab reviewed Nov 11, 2019
View reviewed changes
capture.md Outdated Show resolved Hide resolved
nelsonic and others added 6 commits November 11, 2019 12:43
@nelsonic @SimonLab
fix grammar in sentence: "This is might" > "This might". Thanks @Simo…
537fa14 
…nLab 👍

Co-Authored-By: Simon <labdevsimon@gmail.com>
@iteles @SimonLab
Update link to issue in readme
260b45b 
Co-Authored-By: Simon <labdevsimon@gmail.com>
@iteles @SimonLab
Update link to "categorise" issue in readme
9e9f800 
Co-Authored-By: Simon <labdevsimon@gmail.com>
@iteles @SimonLab
Update capture.md grammar 'of' > 'for'
96622af 
Co-Authored-By: Simon <labdevsimon@gmail.com>
@iteles @SimonLab
Updates link to "capture" first issue in capture.md
e0e39ef 
Co-Authored-By: Simon <labdevsimon@gmail.com>
@nelsonic @SimonLab
add link to Elm PWA thread dwyl/learn-elm#54
4eb1deb 
Co-Authored-By: Simon <labdevsimon@gmail.com>
@nelsonic
Copy link
Member Author

@SimonLab thanks for taking the time to review this PR in such great detail and propose changes. 👍
Lame that the video link is broken ... 😞
Alternative link to Elon Musk "work hard every waking hour": https://youtu.be/liJbB_0eCTo?t=25 📺

I'm a fan of Elon's work ethic and feel that it will inspire/motivate others in our community,
so I'm keen to keep the reference. I'm really not a fan of people who do the bare minimum work and think it's important to set expectations. Note: Not saying that everyone needs to work 80-100 hours per week like Elon. People should decide for themselves what they want in life. If they want "balance" in their 20's more than early retirement in their 30's that's their decision. Nothing "wrong" with it. 👍

SimonLab
SimonLab approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @iteles I'll let you check one last time if you want and merge the PR?

@SimonLab SimonLab assigned iteles and unassigned SimonLab Nov 11, 2019
@iteles
Copy link
Member

iteles commented Nov 11, 2019

👍 Thanks both!

@iteles iteles merged commit bb3888c into master Nov 11, 2019
@iteles iteles deleted the update-what-section-issue#9 branch November 11, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iteles iteles iteles approved these changes

@SimonLab SimonLab SimonLab approved these changes

Assignees

@iteles iteles

Labels
in-review Issue or pull request that is currently being reviewed by the assigned person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nelsonic @iteles @SimonLab