Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Quote Data #1

Closed
8 tasks done
nelsonic opened this issue Sep 30, 2019 · 1 comment
Closed
8 tasks done

Source Quote Data #1

nelsonic opened this issue Sep 30, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@nelsonic
Copy link
Member

nelsonic commented Sep 30, 2019 •
edited

@nelsonic nelsonic added the enhancement New feature or request label Sep 30, 2019
@nelsonic nelsonic added this to To do in Personal Project via automation Sep 30, 2019
nelsonic added a commit that referenced this issue Oct 8, 2019
@nelsonic
add quotes_raw.json to .gitignore to avoid adding unfiltered quotes t…
a78ab7f 
…o quotes.json. #1
nelsonic added a commit that referenced this issue Oct 12, 2019
@nelsonic
add initial batch of 1583 quotes collated from several sources and cl…
8758f01 
…eaned up to remove "nil" and "unknown" authors #1
nelsonic added a commit that referenced this issue Oct 12, 2019
@nelsonic
add function to ETL quotes from various sources. remove duplicates, e…
c938ebc 
…liminate null, nil and "unknown" #1
nelsonic added a commit that referenced this issue Oct 12, 2019
@nelsonic
alphabetise quotes by author and remove unicode characters #1
8ccc507
nelsonic added a commit that referenced this issue Oct 12, 2019
@nelsonic
rename helper module to "utils.ex" for clarity #1
053f2b7
@nelsonic
Copy link
Member Author

done: https://github.com/nelsonic/quotes/blob/master/quotes.json ✅

Personal Project automation moved this from To do to Done Oct 12, 2019
nelsonic added a commit that referenced this issue Oct 12, 2019
@nelsonic
clarify that quotes should not be from unknown authors #1
1c0726a
nelsonic added a commit that referenced this issue Oct 12, 2019
@nelsonic
remove duplicate Andrew Gide quote. dupes are the *worst*! #1
711f50f
nelsonic added a commit that referenced this issue Oct 12, 2019
@nelsonic
add reasoning for removing anon/unkown author quotes to README.md wit…
0af8108 
…h link to Utils.clean #1
nelsonic added a commit that referenced this issue Oct 14, 2019
@nelsonic
add test chat checks all quotes have author and text property #1
fdf3d44
@nelsonic nelsonic removed this from Done in Personal Project Oct 15, 2019
nelsonic added a commit that referenced this issue Oct 15, 2019
@nelsonic
split conditions for removal of quotes in Utils.clean onto separate l…
456d630 
…ines for clarity #1
nelsonic pushed a commit that referenced this issue Feb 24, 2021
@kanishkgpt
Merge pull request #1 from kanishkgpt/kanishkgpt-patch-1
5bf89b8 
Update quotes.json
nelsonic pushed a commit that referenced this issue Jan 17, 2022
@abhideepd
Merge pull request #1 from abhideepd/abhideepd-patch-1
711fbd1 
added "George" to Bernard Shaw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic