Support the #[feign] attribute on trait impls

[NightEule5]

I stumbled onto an unsupported pattern that would be nice to support. I have a trait that can be implemented with get attributes, which works fine:

trait SomeRequest {
    async fn request(&self, id: &str) -> feignhttp::Result<String>;
}

#[derive(Feign)]
struct Struct;

impl SomeRequest for Struct {
    #[get("/some/path/{id}")]
    async fn request(&self, id: &str) -> feignhttp::Result<String> { }
}

But when I add a URL prefix with the feign attribute, it expands to a normal impl without the trait:

#[feign(url = "https://some.url")]
impl SomeRequest for Struct {
    #[get("/some/path/{id}")]
    async fn request(&self, id: &str) -> feignhttp::Result<String> { }
}

// Expands to...

impl Struct {
    async fn request(&self, id: &str) -> feignhttp::Result<String> {
        use feignhttp::FeignClient   as _;
        use std::collections::HashMap;
        use feignhttp::{HttpClient, HttpConfig, HttpResponse, util};
        // ...
    }
}

A workaround is to supply the URL for every request, i.e. #[get(url = "https://some.url", path = "/some/path/{id}")]

[dxx]

Hi!
Traits should not be used to define the method of the request. In the current version of rust, if you define async functions in traits, you must use async-trait crate, but async-trait is conflict with feignhttp.

[NightEule5]

Async traits work in nightly with the async_fn_in_trait feature enabled

[dxx]

Yes. I have pushed a commit 5c993fd.

[dxx]

It is available in 0.5.1 now.