Events are not properly cleaned up

[firasdib]

You add events like this:

target.addEventListener('touchstart', initFn, hasPassive ? { passive: true } : false)

But remove them like this:

target.removeEventListener('touchstart', initFn)

When it should be:

target.removeEventListener('touchstart', initFn, hasPassive ? { passive: true } : false)

[firasdib]

I've fixed the memory leaks in Impetus here: chrisbateman/impetus#41

But the author of that lib does not seem to be active anymore....

Can you use my fork instead? Or is there an alternative library?

[dy]

According to MDN https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/removeEventListener passive option does not matter on removal.

As for the impetus, if you have alternative suggestions let’s consider. Otherwise let’s wait for the merge.

[firasdib]

You're right, { passive: true } does not need to be included. But if you specify capture, either by passing true/false as the third arg, or {capture: true}, you need to include it in the removal process.

While addEventListener() will let you add the same listener more than once for the same type if the options are different, the only option removeEventListener() checks is the capture/useCapture flag.

[firasdib]

Bottom line: it was impetus and my fork fixes it. If the author does not merge it, should I publish it to npm and we use that instead?

[dy]

Let’s wait for a month. For now you can just use github as a dep. Should ping the author periodically

[firasdib]

@dy In that case I need to fork both your repo and his, and use that. Not ideal tbh.

[dy]

@firasdib why don't you just temporarily use your github fork as "pan-zoom": "firasdib/pan-zoom" dependency? If there is no response, I will include your fork as the main entry.

[firasdib]

@dy This is what I am doing now, but forks have a tendency to diverge... :-)