Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better fx deps #35

Closed
dy opened this issue Jul 8, 2019 · 1 comment
Closed

Better fx deps #35

dy opened this issue Jul 8, 2019 · 1 comment
Labels
research Decision-making, arguments, discussion, comparison, design

Comments

@dy
Copy link
Owner

dy commented Jul 8, 2019

React useEffect is pretty poor on deps handling.
fx should user-friendlier compare deps values, as deepEqual.
@dy
Copy link
Owner Author

dy commented Aug 5, 2019

Yes, we do fast-deep,equal

@dy dy closed this as completed Aug 5, 2019
@dy dy added the research Decision-making, arguments, discussion, comparison, design label Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
research Decision-making, arguments, discussion, comparison, design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dy