Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POST support error only triggers on a get method #9

Closed
arcfide opened this issue Feb 17, 2020 · 0 comments · Fixed by #13
Closed

POST support error only triggers on a get method #9

arcfide opened this issue Feb 17, 2020 · 0 comments · Fixed by #13

Comments

@arcfide
Copy link
Contributor

arcfide commented Feb 17, 2020

The following line will only be checked if the method is a 'get' method.

Jarvis/Source/Jarvis.dyalog

Line 561 in d2c5e53

→0 If('Request method should be POST')ns.Req.Fail 405×~HtmlInterface

There are many more methods that might be passed besides 'get' and 'post' and the current handler assumes that if the method is not a 'get' method, then it is a 'post' method.
arcfide added a commit to arcfide/Jarvis that referenced this issue Feb 17, 2020
@arcfide
Verify request method in all location
7e98146 
Fixes Dyalog#9

There is already a check for invalid method calls when the HTML Interface is disabled, but this commit adds a check to the standard path to verify that we only work with 'post' methods in cases where we are called with a non-get method on a valid function but with an invalid request method.
@arcfide arcfide mentioned this issue Feb 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Verify request method in all location arcfide/Jarvis
1 participant
@arcfide