Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link should not use the term "failed to fix", it is confusing #625

Open
mkromberg opened this issue Feb 12, 2024 · 2 comments
Open

Link should not use the term "failed to fix", it is confusing #625

mkromberg opened this issue Feb 12, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mkromberg
Copy link
Contributor

mkromberg commented Feb 12, 2024

      ]link.create # c:\tmp\aplabug
Linked: # ←→ c:\tmp\aplabug [directory was created] 
      (⊂'aaa' 'bbb' 'ccc')⎕NPUT'c:\tmp\aplabug\list.apla'
Link Warning: ⎕SE.Link.Notify: created c:/tmp/aplabug/list.apla: creating #.aaa - failed to fix file
Link Warning: ⎕SE.Link.Notify: changed c:/tmp/aplabug/list.apla: updating un-linked #.aaa - failed to fix file
      ⎕nl -⍳10
(returns nothing)
@mkromberg mkromberg added the bug Something isn't working label Feb 12, 2024
@mkromberg mkromberg added this to the Link 4.0 milestone Feb 12, 2024
@abrudz
Copy link
Member

abrudz commented Feb 27, 2024

The given file should indeed fail to fix, as

aaa
bbb
ccc

isn't valid APLAN.

@mkromberg mkromberg modified the milestones: Link 4.0, Link 5.0 Feb 27, 2024
@mkromberg mkromberg changed the title Link attempt to "fix" .apla files Link should not use the term "failed to fix", it is confusing Feb 27, 2024
@mkromberg
Copy link
Contributor Author

The problem here was that the "failed to fix" led me to believe that we had passed the contents to ⎕FIX rather than trying to de-serialise the array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants