v1.4.0: add recovery endpoint [BAC-2015] #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BAC-2015 GET v3/recovery endpoint for Force-Withdrawals from frontend
Content of the endpoint: If no such account, return a
|
samweinberg23
force-pushed
the
sw_recovery
branch
from
4a78426
to
df2800d
Compare
samweinberg23
force-pushed
the
sw_recovery
branch
from
df2800d
to
ab85e26
Compare
jiajames
reviewed
Oct 28, 2021
src/modules/eth-private.ts
Outdated
Comment on lines
130
to
132
| * @description This is for users who can't recover their starkKey or apiKey and need an | ||
| * additional way to get their starkKey and balance on our exchange, both of which are needed to | ||
| * call the L1 solidity function needed to recover their funds. |
There was a problem hiding this comment.
nit: i think this comment would be better if written from the perspective of the user rather than us, if that makes sense
jiajames
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the api-keys module no longer really works as a name if we include recovery as an eth-private endpoint and it didn't make sense to add a new module for another eth private endpoint so I overhauled the module :(