-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add DELEVERAGING event type to print-block script #1120
Conversation
WalkthroughThe update introduces support for a new event type, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- indexer/services/scripts/src/helpers/block-helpers.ts (2 hunks)
- indexer/services/scripts/src/helpers/types.ts (1 hunks)
Additional comments: 2
indexer/services/scripts/src/helpers/types.ts (1)
- 23-23: The addition of
DELEVERAGING
to theDydxIndexerSubtypes
enum is consistent with the naming convention of existing enum values and aligns with the PR's objective to support a new event type. This change follows best practices for extending enums with new values.indexer/services/scripts/src/helpers/block-helpers.ts (1)
- 103-108: The addition of the
DeleveragingEventV1
case in theannotateIndexerTendermintEvent
function is correctly implemented, following the established pattern for handling different event types. This change aligns with the PR's objective and adheres to best practices for extending switch statements with new cases.Please ensure that the integration of the
DeleveragingEventV1
event type with the rest of the system has been thoroughly tested, especially in terms of event data parsing and display functionality in the print-block script.
Changelist
add DELEVERAGING event type to print-block script
Test Plan
ran on devbox
Author/Reviewer Checklist
state-breaking
label.indexer-postgres-breaking
label.PrepareProposal
orProcessProposal
, manually add the labelproposal-breaking
.feature:[feature-name]
.backport/[branch-name]
.refactor
,chore
,bug
.