Fix mock-gen build

[jonfung-dydx]

It seems that with this pr here we have changed dependencies in the go.mod file.

Now our previous approach of grepping out the version via:

hyperon@Hyperon protocol % go list -m all | grep "github.com/dydxprotocol/cosmos-sdk" 
cosmossdk.io/store v1.0.2 => github.com/dydxprotocol/cosmos-sdk/store v1.0.3-0.20240227194839-f4e166bc1057
github.com/cosmos/cosmos-sdk v0.50.4 => github.com/dydxprotocol/cosmos-sdk v0.50.5-0.20240227194839-f4e166bc1057
hyperon@Hyperon protocol %

is incorrect because there are multiple lines and nested strings.

Fix:

1. add regex to ensure there's no nested strings
2. Remove Marshaler mock gen since there seems to be no more marshaler
3. Account for replaces

Testing:
ran make mock-gen

[coderabbitai]

Walkthrough

The modification updates the build automation for protocol mocks, specifically targeting dependency management and mock generation paths. This adjustment ensures compatibility with newer versions of the Cosmos SDK, reflecting an effort to maintain the project's alignment with its evolving ecosystem.

Changes

Files	Change Summary
protocol/mocks/Makefile	Updated Cosmos SDK versions and adjusted mock generation paths accordingly.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 09dbb7e and 722e9ab.

Files selected for processing (1)

• protocol/mocks/Makefile (2 hunks)

Additional comments: 1

protocol/mocks/Makefile (1)

• 13-14: The mock generation commands for MultiStore and CacheMultiStore have been updated to reflect the new dependency versions. This change is part of the optimization process to ensure that mocks are generated based on the current versions of dependencies. It's important to verify that these changes do not introduce any issues with the mock generation process, especially considering the dependency on specific versions.

Ensure that the updated mock generation commands work as expected by running make mock-gen and verifying the output. Additionally, review the impact of these changes on the overall build process and any dependent components.

[coderabbitai]

The approach to identify dependency versions using go list -m all | grep ... | awk '{print $$NF}' is improved to handle multiple lines and nested strings. This is a crucial fix for ensuring accurate version identification. However, consider using more specific regex patterns or tools like sed for even more robust parsing, especially if the output format of go list -m all might vary or include unexpected characters in future versions of Go.

Consider refining the regex pattern or using sed for more robust parsing to ensure future-proof version identification.

[jonfung-dydx]

Can you write me the equivalent sed command please?

[coderabbitai]

The equivalent sed commands for extracting the dependency versions, replacing the combination of grep and awk, are as follows:

COSMOS_VERSION=$(go list -m all | sed -n 's/^github.com\/dydxprotocol\/cosmos-sdk[^/]* \([^ ]*\)$/\1/p')
COSMOS_STORE_VERSION=$(go list -m all | sed -n 's/^cosmossdk.io\/store[^/]* \([^ ]*\)$/\1/p')
COSMOS_LOG_VERSION=$(go list -m all | sed -n 's/^cosmossdk.io\/log[^/]* \([^ ]*\)$/\1/p')
COSMOS_GOGOPROTO_VERSION=$(go list -m all | sed -n 's/^github.com\/cosmos\/gogoproto[^/]* \([^ ]*\)$/\1/p')

These commands use sed to search for lines matching the specified patterns and then extract and print the version numbers found at the end of those lines. The -n flag suppresses automatic printing, and the s///p structure is used for substitution and printing of matched lines.