[OTE-209] Emit metrics gated through execution mode #1157
Conversation
WalkthroughThe modifications involve enhancing telemetry functionalities within a blockchain protocol's codebase. Specifically, the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
protocol/lib/metrics/util.go
Outdated
| func ContextuallySetGaugeWithLabels( | ||
| ctx sdk.Context, | ||
| keys []string, | ||
| val float32, | ||
| labels []gometrics.Label, | ||
| modes []sdk.ExecMode, | ||
| ) { | ||
| contextExecMode := ctx.ExecMode() | ||
| for _, mode := range modes { | ||
| if contextExecMode == mode { | ||
| telemetry.SetGaugeWithLabels(keys, val, labels) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The ContextuallySetGaugeWithLabels function introduces a conditional gauge setting based on execution modes, which is a valuable addition for context-sensitive metrics emission. However, there are a couple of areas that could be improved for robustness and efficiency:
- Parameter Validation: It's generally a good practice to validate inputs to public functions. Consider adding checks for nil or empty inputs (e.g.,
ctx,keys,labels,modes) to prevent potential runtime errors. - Loop Optimization: If the list of
modesis expected to grow large, consider optimizing the loop to break early once a match is found, as there's no need to continue iterating once the gauge has been set.
func ContextuallySetGaugeWithLabels(
ctx sdk.Context,
keys []string,
val float32,
labels []gometrics.Label,
modes []sdk.ExecMode,
) {
+ if ctx == nil || len(keys) == 0 || len(modes) == 0 {
+ return // Consider logging or handling the error as appropriate
+ }
contextExecMode := ctx.ExecMode()
for _, mode := range modes {
if contextExecMode == mode {
telemetry.SetGaugeWithLabels(keys, val, labels)
+ break // Exit the loop early once a match is found
}
}
}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| func ContextuallySetGaugeWithLabels( | |
| ctx sdk.Context, | |
| keys []string, | |
| val float32, | |
| labels []gometrics.Label, | |
| modes []sdk.ExecMode, | |
| ) { | |
| contextExecMode := ctx.ExecMode() | |
| for _, mode := range modes { | |
| if contextExecMode == mode { | |
| telemetry.SetGaugeWithLabels(keys, val, labels) | |
| } | |
| } | |
| } | |
| func ContextuallySetGaugeWithLabels( | |
| ctx sdk.Context, | |
| keys []string, | |
| val float32, | |
| labels []gometrics.Label, | |
| modes []sdk.ExecMode, | |
| ) { | |
| if ctx == nil || len(keys) == 0 || len(modes) == 0 { | |
| return // Consider logging or handling the error as appropriate | |
| } | |
| contextExecMode := ctx.ExecMode() | |
| for _, mode := range modes { | |
| if contextExecMode == mode { | |
| telemetry.SetGaugeWithLabels(keys, val, labels) | |
| break // Exit the loop early once a match is found | |
| } | |
| } | |
| } |
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (2)
- protocol/lib/metrics/util_test.go (2 hunks)
- protocol/x/sending/keeper/transfer.go (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- protocol/x/sending/keeper/transfer.go
Additional comments: 1
protocol/lib/metrics/util_test.go (1)
- 9-9: The addition of the Cosmos SDK (
sdk "github.com/cosmos/cosmos-sdk/types") import is appropriate for the context of the new test functionTestSetGaugeWithLabelsAndContext, which utilizes thesdk.Contexttype. This change aligns with the PR objectives related to enhancing metrics emission based on execution modes.
protocol/lib/metrics/util_test.go
Outdated
| func TestSetGaugeWithLabelsAndContext(t *testing.T) { | ||
| t.Cleanup(gometrics.Shutdown) | ||
| context := sdk.Context{} | ||
| conf := gometrics.DefaultConfig("testService") | ||
| conf.EnableHostname = false | ||
| sink := gometrics.NewInmemSink(time.Hour, time.Hour) | ||
| _, err := gometrics.NewGlobal(conf, sink) | ||
| require.NoError(t, err) | ||
|
|
||
| context = context.WithExecMode(sdk.ExecModeFinalize) | ||
| metrics.ContextuallySetGaugeWithLabels( | ||
| context, | ||
| []string{"testKey1"}, | ||
| 3.14, | ||
| []gometrics.Label{{ | ||
| Name: "testLabel", | ||
| Value: "testLabelValue", | ||
| }}, | ||
| []sdk.ExecMode{sdk.ExecModeFinalize}, | ||
| ) | ||
|
|
||
| metrics.ContextuallySetGaugeWithLabels( | ||
| context, | ||
| []string{"testKey2"}, | ||
| 3.14, | ||
| []gometrics.Label{{ | ||
| Name: "testLabel", | ||
| Value: "testLabelValue", | ||
| }}, | ||
| []sdk.ExecMode{sdk.ExecModeSimulate}, | ||
| ) | ||
|
|
||
| FinalizeModeKeyFound := false | ||
| SimateModeKeyFound := false | ||
| for _, metrics := range sink.Data() { | ||
| metrics.RLock() | ||
| defer metrics.RUnlock() | ||
|
|
||
| if metric, ok := metrics.Gauges["testService.testKey1;testLabel=testLabelValue"]; ok { | ||
| require.Equal(t, | ||
| []gometrics.Label{{ | ||
| Name: "testLabel", | ||
| Value: "testLabelValue", | ||
| }}, | ||
| metric.Labels) | ||
| require.Equal(t, float32(3.14), metric.Value) | ||
| FinalizeModeKeyFound = true | ||
| } | ||
| if _, ok := metrics.Gauges["testService.testKey2;testLabel=testLabelValue"]; ok { | ||
| SimateModeKeyFound = true | ||
| } | ||
| } | ||
| require.True(t, FinalizeModeKeyFound) | ||
| require.False(t, SimateModeKeyFound) | ||
| } |
There was a problem hiding this comment.
The TestSetGaugeWithLabelsAndContext function effectively tests the ContextuallySetGaugeWithLabels method under different execution modes (sdk.ExecModeFinalize and sdk.ExecModeSimulate). The test ensures that metrics are only emitted for the specified execution modes, aligning with the PR's objectives. However, there's a typo in the variable name SimateModeKeyFound (line 280), which should be corrected to SimulateModeKeyFound for clarity and consistency.
- Correct the typo in the variable name for consistency and clarity.
- SimateModeKeyFound := false
+ SimulateModeKeyFound := falseAdditionally, consider adding more comments to describe the purpose of each block within the test function, especially for the setup and the different scenarios being tested. This will improve the maintainability and readability of the test code.
- Enhance code comments for better readability and maintainability.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| func TestSetGaugeWithLabelsAndContext(t *testing.T) { | |
| t.Cleanup(gometrics.Shutdown) | |
| context := sdk.Context{} | |
| conf := gometrics.DefaultConfig("testService") | |
| conf.EnableHostname = false | |
| sink := gometrics.NewInmemSink(time.Hour, time.Hour) | |
| _, err := gometrics.NewGlobal(conf, sink) | |
| require.NoError(t, err) | |
| context = context.WithExecMode(sdk.ExecModeFinalize) | |
| metrics.ContextuallySetGaugeWithLabels( | |
| context, | |
| []string{"testKey1"}, | |
| 3.14, | |
| []gometrics.Label{{ | |
| Name: "testLabel", | |
| Value: "testLabelValue", | |
| }}, | |
| []sdk.ExecMode{sdk.ExecModeFinalize}, | |
| ) | |
| metrics.ContextuallySetGaugeWithLabels( | |
| context, | |
| []string{"testKey2"}, | |
| 3.14, | |
| []gometrics.Label{{ | |
| Name: "testLabel", | |
| Value: "testLabelValue", | |
| }}, | |
| []sdk.ExecMode{sdk.ExecModeSimulate}, | |
| ) | |
| FinalizeModeKeyFound := false | |
| SimateModeKeyFound := false | |
| for _, metrics := range sink.Data() { | |
| metrics.RLock() | |
| defer metrics.RUnlock() | |
| if metric, ok := metrics.Gauges["testService.testKey1;testLabel=testLabelValue"]; ok { | |
| require.Equal(t, | |
| []gometrics.Label{{ | |
| Name: "testLabel", | |
| Value: "testLabelValue", | |
| }}, | |
| metric.Labels) | |
| require.Equal(t, float32(3.14), metric.Value) | |
| FinalizeModeKeyFound = true | |
| } | |
| if _, ok := metrics.Gauges["testService.testKey2;testLabel=testLabelValue"]; ok { | |
| SimateModeKeyFound = true | |
| } | |
| } | |
| require.True(t, FinalizeModeKeyFound) | |
| require.False(t, SimateModeKeyFound) | |
| } | |
| func TestSetGaugeWithLabelsAndContext(t *testing.T) { | |
| t.Cleanup(gometrics.Shutdown) | |
| context := sdk.Context{} | |
| conf := gometrics.DefaultConfig("testService") | |
| conf.EnableHostname = false | |
| sink := gometrics.NewInmemSink(time.Hour, time.Hour) | |
| _, err := gometrics.NewGlobal(conf, sink) | |
| require.NoError(t, err) | |
| context = context.WithExecMode(sdk.ExecModeFinalize) | |
| metrics.ContextuallySetGaugeWithLabels( | |
| context, | |
| []string{"testKey1"}, | |
| 3.14, | |
| []gometrics.Label{{ | |
| Name: "testLabel", | |
| Value: "testLabelValue", | |
| }}, | |
| []sdk.ExecMode{sdk.ExecModeFinalize}, | |
| ) | |
| metrics.ContextuallySetGaugeWithLabels( | |
| context, | |
| []string{"testKey2"}, | |
| 3.14, | |
| []gometrics.Label{{ | |
| Name: "testLabel", | |
| Value: "testLabelValue", | |
| }}, | |
| []sdk.ExecMode{sdk.ExecModeSimulate}, | |
| ) | |
| FinalizeModeKeyFound := false | |
| SimulateModeKeyFound := false | |
| for _, metrics := range sink.Data() { | |
| metrics.RLock() | |
| defer metrics.RUnlock() | |
| if metric, ok := metrics.Gauges["testService.testKey1;testLabel=testLabelValue"]; ok { | |
| require.Equal(t, | |
| []gometrics.Label{{ | |
| Name: "testLabel", | |
| Value: "testLabelValue", | |
| }}, | |
| metric.Labels) | |
| require.Equal(t, float32(3.14), metric.Value) | |
| FinalizeModeKeyFound = true | |
| } | |
| if _, ok := metrics.Gauges["testService.testKey2;testLabel=testLabelValue"]; ok { | |
| SimulateModeKeyFound = true | |
| } | |
| } | |
| require.True(t, FinalizeModeKeyFound) | |
| require.False(t, SimulateModeKeyFound) | |
| } |
affanv14
changed the title
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- protocol/lib/metrics/util_test.go (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- protocol/lib/metrics/util_test.go
affanv14
force-pushed
the
affan/context-set-gauge
branch
from
db4c9e0
to
2784b4c
Compare
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (3)
- protocol/lib/metrics/lib.go (3 hunks)
- protocol/lib/metrics/lib_test.go (1 hunks)
- protocol/x/sending/keeper/transfer.go (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- protocol/lib/metrics/lib.go
- protocol/x/sending/keeper/transfer.go
protocol/lib/metrics/lib_test.go
Outdated
| func TestSetGaugeWithLabelsAndContext(t *testing.T) { | ||
| t.Cleanup(gometrics.Shutdown) | ||
| context := sdk.Context{} | ||
| conf := gometrics.DefaultConfig("testService") | ||
| conf.EnableHostname = false | ||
| sink := gometrics.NewInmemSink(time.Hour, time.Hour) | ||
| _, err := gometrics.NewGlobal(conf, sink) | ||
| require.NoError(t, err) | ||
|
|
||
| context = context.WithExecMode(sdk.ExecModeFinalize) | ||
| metrics.EmitTelemetryWithLabelsForExecMode( | ||
| context, | ||
| []sdk.ExecMode{sdk.ExecModeFinalize}, | ||
| telemetry.SetGaugeWithLabels, | ||
| []string{"testKey1"}, | ||
| 3.14, | ||
| []gometrics.Label{{ | ||
| Name: "testLabel", | ||
| Value: "testLabelValue", | ||
| }}, | ||
| ) | ||
|
|
||
| metrics.EmitTelemetryWithLabelsForExecMode( | ||
| context, | ||
| []sdk.ExecMode{sdk.ExecModeSimulate}, | ||
| telemetry.SetGaugeWithLabels, | ||
| []string{"testKey2"}, | ||
| 3.14, | ||
| []gometrics.Label{{ | ||
| Name: "testLabel", | ||
| Value: "testLabelValue", | ||
| }}, | ||
| ) | ||
|
|
||
| FinalizeModeKeyFound := false | ||
| SimulateModeKeyFound := false | ||
| for _, metrics := range sink.Data() { | ||
| metrics.RLock() | ||
| defer metrics.RUnlock() | ||
|
|
||
| if metric, ok := metrics.Gauges["testService.testKey1;testLabel=testLabelValue"]; ok { | ||
| require.Equal(t, | ||
| []gometrics.Label{{ | ||
| Name: "testLabel", | ||
| Value: "testLabelValue", | ||
| }}, | ||
| metric.Labels) | ||
| require.Equal(t, float32(3.14), metric.Value) | ||
| FinalizeModeKeyFound = true | ||
| } | ||
| if _, ok := metrics.Gauges["testService.testKey2;testLabel=testLabelValue"]; ok { | ||
| SimulateModeKeyFound = true | ||
| } | ||
| } | ||
| require.True(t, FinalizeModeKeyFound) | ||
| require.False(t, SimulateModeKeyFound) | ||
| } |
There was a problem hiding this comment.
The test function TestSetGaugeWithLabelsAndContext is well-structured and tests the new functionality of selective metrics emission based on execution modes. However, there are a few areas that could be improved for clarity and maintainability:
-
Use of
deferinside a loop (lines 52-53): Usingdeferinside a loop can lead to deferred calls not being executed until the end of the function, which might not be the intended behavior, especially when working with locks. It's recommended to extract the loop body into a separate function or manually manage locking and unlocking to ensure that locks are released as soon as they are no longer needed. -
Testing for both execution modes: The test validates that metrics are emitted for
ExecModeFinalizeand not emitted forExecModeSimulate, which aligns with the PR objectives. However, it might be beneficial to add comments explaining the rationale behind these checks to make the test intentions clearer to future maintainers. -
Magic numbers and strings: The test uses magic numbers (e.g.,
3.14) and strings (e.g.,"testKey1","testLabel","testLabelValue") without explanation. Using named constants or variables with descriptive names could improve readability and maintainability. -
Error handling: While
require.NoError(t, err)is used to assert that no error occurs during the setup phase, it's also important to ensure that the test fails gracefully if any unexpected behavior occurs during the metrics emission or validation phases. Adding more granular error checks or assertions could enhance the robustness of the test. -
Test coverage: This test covers the basic functionality of the selective metrics emission. However, considering the importance of this feature, it might be worthwhile to add more test cases covering edge cases or other execution modes if applicable.
Consider addressing these points to improve the test's clarity, maintainability, and robustness.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- protocol/lib/metrics/lib.go (3 hunks)
- protocol/lib/metrics/lib_test.go (1 hunks)
- protocol/x/sending/keeper/transfer.go (2 hunks)
Files skipped from review as they are similar to previous changes (2)
- protocol/lib/metrics/lib.go
- protocol/x/sending/keeper/transfer.go
Additional comments: 1
protocol/lib/metrics/lib_test.go (1)
- 14-70: The test
TestSetGaugeWithLabelsForExecModeis well-structured and tests the functionality ofEmitTelemetryWithLabelsForExecModeunder different execution modes. However, there are a few areas for improvement and clarification:
Deferred Unlock in a Loop (Lines 51-52): Using
deferinside a loop can lead to resource exhaustion or delayed release of locks until the function exits. It's more efficient to manually unlock after the necessary operations are completed within the loop.Testing for Negative Cases: While the test checks that metrics are correctly emitted under the
sdk.ExecModeFinalizeand not undersdk.ExecModeSimulate, it would be beneficial to include more negative test cases or edge cases to ensure robustness. For example, testing with an empty execution mode or an execution mode that is not part of the allowed list could uncover potential issues.Use of Magic Numbers and Strings: The test uses literals such as "testService", "testKey1", "testKey2", and "testLabelValue" multiple times. Consider defining these as constants at the beginning of your test file to improve maintainability and readability.
Asserting on
SimulateModeKeyFound: The assertionrequire.False(t, SimulateModeKeyFound)validates that no telemetry is emitted forsdk.ExecModeSimulate. This is a good practice as it checks the functionality explicitly. However, adding a comment explaining why this behavior is expected (i.e.,sdk.ExecModeSimulateshould not emit telemetry) would improve code readability and maintainability.Improving Test Coverage: The test covers the basic functionality but does not test all possible execution modes or combinations thereof. Expanding the test cases to cover more scenarios would ensure the system behaves as expected under various conditions.
- defer metrics.RUnlock() + metrics.RUnlock() // Move this line appropriately inside the loop after the necessary operations are completed.Consider adding more negative test cases, using constants for repeated literals, and expanding the test coverage to include various scenarios and execution modes.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- protocol/lib/metrics/metric_keys.go (1 hunks)
- protocol/x/sending/keeper/transfer.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- protocol/x/sending/keeper/transfer.go
Additional comments: 1
protocol/lib/metrics/metric_keys.go (1)
- 34-34: The addition of the metric key
SendingProcessDepositToSubaccountaligns with the established guidelines for metric keys, including prefixing by module, suffixing with a unit of measurement where applicable, and using underscores for delimitation. This addition is well-placed within the 'Gauges' section, indicating it represents a current state value that can change over time.However, it's important to ensure that the naming of this metric key, and others within the system, remains clear and consistent. Consider reviewing the naming conventions used across the metrics system to ensure they accurately and clearly represent the data being measured, especially as the system evolves and more metrics are added.
affanv14
changed the title
Signed-off-by: Eric <eric.warehime@gmail.com>
Signed-off-by: Eric <eric.warehime@gmail.com>
Signed-off-by: Eric <eric.warehime@gmail.com>
commit d98f859 Author: Eric <eric.warehime@gmail.com> Date: Mon Mar 11 12:46:53 2024 -0700 Update sample pregenesis Signed-off-by: Eric <eric.warehime@gmail.com> commit 7f178fe Author: Mohammed Affan <affanmd@nyu.edu> Date: Mon Mar 11 13:46:08 2024 -0400 [OTE-209] Emit metrics gated through execution mode (dydxprotocol#1157) Signed-off-by: Eric <eric.warehime@gmail.com> commit 47e365d Author: dydxwill <119354122+dydxwill@users.noreply.github.com> Date: Mon Mar 11 13:43:16 2024 -0400 add aggregate comlink response code stats (dydxprotocol#1162) Signed-off-by: Eric <eric.warehime@gmail.com> commit 7774ad9 Author: shrenujb <98204323+shrenujb@users.noreply.github.com> Date: Fri Mar 8 17:30:49 2024 -0500 [TRA-70] Add state migrations for isolated markets (dydxprotocol#1155) Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange> Signed-off-by: Eric <eric.warehime@gmail.com> commit 89c7405 Author: Jonathan Fung <121899091+jonfung-dydx@users.noreply.github.com> Date: Thu Mar 7 17:28:06 2024 -0500 [CT-517] E2E tests batch cancel (dydxprotocol#1149) * more end to end test * extraprint * more e2e test Signed-off-by: Eric <eric.warehime@gmail.com> commit 41a3a41 Author: Teddy Ding <teddy@dydx.exchange> Date: Thu Mar 7 15:42:30 2024 -0500 [OTE-200] OIMF protos (dydxprotocol#1125) * OIMF protos * add default genesis value, modify methods interface * fix genesis file * fix integration test * lint Signed-off-by: Eric <eric.warehime@gmail.com> commit 2a062b1 Author: Teddy Ding <teddy@dydx.exchange> Date: Thu Mar 7 15:24:15 2024 -0500 Add `v5` upgrade handler and set up container upgrade test (dydxprotocol#1153) * wip * update preupgrade_genesis * fix preupgrade_genesis.json * nit * setupUpgradeStoreLoaders for v5.0.0 Signed-off-by: Eric <eric.warehime@gmail.com> commit b7942b3 Author: jayy04 <103467857+jayy04@users.noreply.github.com> Date: Thu Mar 7 13:43:48 2024 -0500 [CT-647] construct the initial orderbook snapshot (dydxprotocol#1147) * [CT-647] construct the initial orderbook snapshot * [CT-647] initialize new streams and send orderbook snapshot (dydxprotocol#1152) * [CT-647] initialize new streams and send orderbook snapshot * use sync once * comments Signed-off-by: Eric <eric.warehime@gmail.com> commit c67a3c6 Author: shrenujb <98204323+shrenujb@users.noreply.github.com> Date: Thu Mar 7 12:40:37 2024 -0500 [TRA-84] Move SA module address transfers to use perpetual based SA accounts (dydxprotocol#1146) Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange Signed-off-by: Eric <eric.warehime@gmail.com> commit dba23e0 Author: Mohammed Affan <affanmd@nyu.edu> Date: Thu Mar 7 10:34:11 2024 -0500 update readme link to point to the right page (dydxprotocol#1151) Signed-off-by: Eric <eric.warehime@gmail.com> commit b5870d5 Author: Tian <tian@dydx.exchange> Date: Wed Mar 6 16:43:04 2024 -0500 [TRA-86] scaffold x/vault (dydxprotocol#1148) * scaffold x/vault Signed-off-by: Eric <eric.warehime@gmail.com> commit 0eca041 Author: jayy04 <103467857+jayy04@users.noreply.github.com> Date: Wed Mar 6 10:48:42 2024 -0500 [CT-652] add command line flag for full node streaming (dydxprotocol#1145) Signed-off-by: Eric <eric.warehime@gmail.com> commit b319cb8 Author: jayy04 <103467857+jayy04@users.noreply.github.com> Date: Tue Mar 5 21:58:35 2024 -0500 [CT-646] stream offchain updates through stream manager (dydxprotocol#1138) * [CT-646] stream offchain updates through stream manager * comments * fix lint * get rid of finished * comments * comments Signed-off-by: Eric <eric.warehime@gmail.com> commit 1c54620 Author: shrenujb <98204323+shrenujb@users.noreply.github.com> Date: Tue Mar 5 16:34:19 2024 -0500 [TRA-78] Add function to retrieve collateral pool addr for a subaccount (dydxprotocol#1142) Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange> Signed-off-by: Eric <eric.warehime@gmail.com> commit b8c1d62 Author: dydxwill <119354122+dydxwill@users.noreply.github.com> Date: Tue Mar 5 15:03:28 2024 -0500 [OTE-141] implement post /compliance/geoblock (dydxprotocol#1129) Signed-off-by: Eric <eric.warehime@gmail.com> commit ab8c570 Author: Jonathan Fung <121899091+jonfung-dydx@users.noreply.github.com> Date: Tue Mar 5 11:19:53 2024 -0500 Fix mock-gen dydxprotocol#1140 Signed-off-by: Eric <eric.warehime@gmail.com> commit 12506a1 Author: shrenujb <98204323+shrenujb@users.noreply.github.com> Date: Mon Mar 4 21:33:28 2024 -0500 [TRA-64] Use market specific insurance fund for cross or isolated markets (dydxprotocol#1132) Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange> Signed-off-by: Eric <eric.warehime@gmail.com> commit 929f09e Author: Jonathan Fung <121899091+jonfung-dydx@users.noreply.github.com> Date: Mon Mar 4 13:48:04 2024 -0800 [CT-514] Clob `MsgBatchCancel` functionality (dydxprotocol#1110) * wip implementation * use new cometbft * Revert "use new cometbft" This reverts commit e5b8a03. * go mod tidy * basic e2e test * more msgBatchCancels in code * repeated fixed32 -> uint32 * remove debug prints * update cometbft replace go.mod sha * one more debug print * typo * regen indexer protos * update comment on proto * proto comment changes * extract stateful validation into own fn * pr format comments * clean up test file * new return type with success and failure Signed-off-by: Eric <eric.warehime@gmail.com> commit 41de83e Author: dydxwill <119354122+dydxwill@users.noreply.github.com> Date: Mon Mar 4 12:22:16 2024 -0500 add index to address read replica lag (dydxprotocol#1137) Signed-off-by: Eric <eric.warehime@gmail.com> commit 735d9a8 Author: dydxwill <119354122+dydxwill@users.noreply.github.com> Date: Mon Mar 4 11:56:59 2024 -0500 rename (dydxprotocol#1136) Signed-off-by: Eric <eric.warehime@gmail.com> commit 86617dd Author: jayy04 <103467857+jayy04@users.noreply.github.com> Date: Mon Mar 4 10:43:31 2024 -0500 [CT-644] instantiate grpc stream manager (dydxprotocol#1134) * [CT-644] instantiate grpc stream manager * update type * update channel type Signed-off-by: Eric <eric.warehime@gmail.com> commit 32afd64 Author: Eric <eric.warehime@gmail.com> Date: Mon Mar 11 12:41:06 2024 -0700 Update go version in Dockerfile Signed-off-by: Eric <eric.warehime@gmail.com> commit ba27204 Author: Eric <eric.warehime@gmail.com> Date: Fri Mar 8 09:44:04 2024 -0800 Add slinky utils, use that to convert between market and currency pair commit 667a804 Author: Eric <eric.warehime@gmail.com> Date: Wed Mar 6 20:43:40 2024 -0800 Update error messages commit d53292c Author: Eric <eric.warehime@gmail.com> Date: Wed Mar 6 20:16:01 2024 -0800 Update docstrings, rename OracleClient commit daad125 Author: Eric <eric.warehime@gmail.com> Date: Mon Mar 4 10:51:23 2024 -0800 VoteExtension slinky logic
Changelist
Test Plan
Added a test which checks which whether the metric is emitted based on the mode pass through
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.