Disable fast nodes and update iavl to address bugs

[roy-dydx]

Changelist

• iavl upgrade fixes bugs
  • Legacy nodes being pruned when they are still being referenced
  • Hash incorrectly generated for some nodes that maintained child references to legacy nodes (but actually reference non-legacy nodes during tree modifications
  • SaveVersion incorrectly thinks that tree is unmodified if a previous leaf becomes the new root
• turning fast nodes off because they are not supposed to be useful in iavl v1

Test Plan

• Successfully synced on testnet and none of the bugs occur

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

[coderabbitai]

Walkthrough

This update introduces a new configuration option within the base application initialization process. It specifically adds the ability to disable the fast node feature in the IAVL cache. This adjustment aims to provide users with more control over their application's performance and resource management, potentially optimizing for scenarios where the fast node's benefits do not outweigh its costs.

Changes

File Path	Change Summary
protocol/.../root.go	Added a new setting to disable fast node in the IAVL cache for base application initialization.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 6bcd294 and 20368d5.

Files ignored due to path filters (2)

• protocol/go.mod is excluded by: !**/*.mod
• protocol/go.sum is excluded by: !**/*.sum

Files selected for processing (1)

• protocol/cmd/dydxprotocold/cmd/root.go (1 hunks)

Additional comments: 1

protocol/cmd/dydxprotocold/cmd/root.go (1)

• 390-390: The change to disable fast nodes in the IAVL cache by setting SetIAVLDisableFastNode(true) directly addresses the PR's objective to improve data integrity and consistency. This is a crucial configuration change that aligns with the goals of the IAVL v1 implementation.

Please ensure to assess the impact of this change on the overall performance of the system. Additionally, it's important to update any relevant documentation to reflect this significant configuration change.

[roy-dydx]

Test coverage failing due to some slinky changes. Unrelated.