Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decouple grpc and non validating full node flags #1400

Merged
merged 1 commit into from
Apr 23, 2024
Merged

decouple grpc and non validating full node flags #1400

merged 1 commit into from
Apr 23, 2024

Conversation

jayy04
Copy link
Contributor

@jayy04 jayy04 commented Apr 23, 2024

Changelist

[Describe or list the changes made in this PR]

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 23, 2024 •
edited

Walkthrough

The recent modifications involve changes to the validation logic and testing descriptions in the Flags struct. Specifically, a condition checking settings for non-validating full nodes has been removed, streamlining the code. Additionally, test cases in the associated test file have been updated to reflect new expectations for gRPC streaming scenarios on validating nodes, including revised success and failure conditions and corresponding error messages.

Changes

Files Change Summary
.../flags/flags.go Removed condition related to NonValidatingFullNode in the Validate method.
.../flags/flags_test.go Updated test descriptions and expected outcomes for gRPC streaming scenarios on validating nodes. Adjusted error messages accordingly.
Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 30b926d and dda6b0f.
Files selected for processing (2)
  • protocol/app/flags/flags.go (1 hunks)
  • protocol/app/flags/flags_test.go (1 hunks)
Additional Context Used
Path-based Instructions (2)
protocol/app/flags/flags_test.go (1)

Pattern **/**: Do not include a walkthrough. For all comments on line changes that are longer than 15 lines, add a prefix to the comment of what lines you are commenting on (for example: "The changes from lines 100 to 200...". Add your comment to be on the last 15 lines of the chunk rather than adding your comment to the entire chunk.

protocol/app/flags/flags.go (1)

Pattern **/**: Do not include a walkthrough. For all comments on line changes that are longer than 15 lines, add a prefix to the comment of what lines you are commenting on (for example: "The changes from lines 100 to 200...". Add your comment to be on the last 15 lines of the chunk rather than adding your comment to the entire chunk.

Additional comments not posted (3)
protocol/app/flags/flags_test.go (2)

64-70: The changes from lines 64 to 70 reflect the updated logic where gRPC streaming is now considered valid for validating nodes. This aligns with the PR's objective to decouple certain flag validations.

71-75: The changes from lines 71 to 75 correctly adjust the expected error message to reflect the new validation logic that gRPC must be enabled. This is a necessary update following the logic changes in the main flags handling code.

protocol/app/flags/flags.go (1)

Line range hint 64-70: The removal of the condition checking NonValidatingFullNode in the Validate method simplifies the validation logic and is in line with the PR's objective to decouple this flag from others. This change should make the flag handling more straightforward and less error-prone.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jayy04
Copy link
Contributor Author

jayy04 commented Apr 23, 2024

https://github.com/Mergifyio backport release/protocol/v4.1.x

@jayy04
Copy link
Contributor Author

jayy04 commented Apr 23, 2024

https://github.com/Mergifyio backport release/protocol/v5.x

@mergify Mergify
Copy link

mergify bot commented Apr 23, 2024 •
edited

backport release/protocol/v4.1.x

✅ Backports have been created

@mergify Mergify
Copy link

mergify bot commented Apr 23, 2024 •
edited

backport release/protocol/v5.x

✅ Backports have been created

@jayy04 jayy04 merged commit 2fffe31 into main Apr 23, 2024
17 checks passed
@jayy04 jayy04 deleted the jy/decouple-grpc-flags branch April 23, 2024 19:11
mergify bot pushed a commit that referenced this pull request Apr 23, 2024
@jayy04 @mergify
decouple grpc and non validating full node flags (#1400)
73d5ca7 
(cherry picked from commit 2fffe31)
mergify bot pushed a commit that referenced this pull request Apr 23, 2024
@jayy04 @mergify
decouple grpc and non validating full node flags (#1400)
10ad741 
(cherry picked from commit 2fffe31)
This was referenced Apr 23, 2024
Merged
Merged
jayy04 added a commit that referenced this pull request Apr 23, 2024
@mergify @jayy04
decouple grpc and non validating full node flags (#1400) (#1404)
0f11da7 
(cherry picked from commit 2fffe31)

Co-authored-by: jayy04 <103467857+jayy04@users.noreply.github.com>
jayy04 added a commit that referenced this pull request Apr 23, 2024
@mergify @jayy04
decouple grpc and non validating full node flags (#1400) (#1405)
1598800 
(cherry picked from commit 2fffe31)

Co-authored-by: jayy04 <103467857+jayy04@users.noreply.github.com>
@jayy04
Copy link
Contributor Author

jayy04 commented Apr 25, 2024

https://github.com/Mergifyio backport release/protocol/v4.x

@mergify Mergify
Copy link

mergify bot commented Apr 25, 2024 •
edited

backport release/protocol/v4.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 25, 2024
@jayy04 @mergify
decouple grpc and non validating full node flags (#1400)
93b609e 
(cherry picked from commit 2fffe31)
@mergify mergify bot mentioned this pull request Apr 25, 2024
Merged
6 tasks
jayy04 added a commit that referenced this pull request Apr 25, 2024
@mergify @jayy04
decouple grpc and non validating full node flags (#1400) (#1414)
4195498 
(cherry picked from commit 2fffe31)

Co-authored-by: jayy04 <103467857+jayy04@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teddyding teddyding teddyding approved these changes

Assignees
No one assigned
Labels
protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jayy04 @teddyding