[DEC-2155] Set gov.params.min_initial_deposit_ratio to 0.2 to avoid spamming
#670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes primarily involve the modification of genesis parameters across different environments (production, public testnet, and other testing environments). The Changes
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Files selected for processing (2)
- protocol/scripts/genesis/prod_pregenesis.sh (1 hunks)
- protocol/testing/genesis.sh (1 hunks)
Files skipped from review due to trivial changes (1)
- protocol/testing/genesis.sh
Additional comments (Suppressed): 1
protocol/scripts/genesis/prod_pregenesis.sh (1)
- 110-110: The new line introduces a
min_initial_deposit_ratioparameter set to 20%. This change is intended to mitigate the issue of government proposal spamming by requiring a minimum initial deposit ratio of 20% to create a government proposal. Ensure that this change aligns with the overall system design and does not inadvertently affect other parts of the system.
tqin7
approved these changes
Oct 19, 2023
tqin7
reviewed
Oct 19, 2023
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Files ignored due to filter (1)
- protocol/scripts/genesis/sample_pregenesis.json
Files selected for processing (1)
- protocol/testing/testnet-external/pregenesis.sh (1 hunks)
Additional comments (Suppressed): 1
protocol/testing/testnet-external/pregenesis.sh (1)
- 161-164: The new hunk introduces a change to the
min_initial_deposit_ratioparameter in the genesis file, setting it to 20%. This change is in line with the PR's goal of mitigating government proposal spamming. However, it's important to verify that this change doesn't negatively impact the proposal creation process, especially for legitimate proposals. Also, ensure that this change is communicated to all relevant stakeholders, as it may affect their interactions with the system.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Files selected for processing (1)
- protocol/testing/genesis.sh (1 hunks)
Additional comments (Suppressed): 1
protocol/testing/genesis.sh (1)
- 82-87: The changes made to the
max_deposit_period,voting_period, andmin_initial_deposit_ratioparameters are consistent with the PR summary. However, ensure that these changes are compatible with the rest of the system and that they do not negatively impact the user experience or the system's performance. Also, verify that the newmin_initial_deposit_ratioof 0.2 (20%) is an appropriate value to prevent spamming without hindering legitimate users.
|
@Mergifyio backport release/protocol/v1.x |
✅ Backports have been created
|
ttl33
added a commit
that referenced
this pull request
Oct 20, 2023
… spamming (backport #670) (#680) * [DEC-2155] Set `gov.params.min_initial_deposit_ratio` to 0.2 to avoid spamming (#670) * use 0.20 to avoid spam * run make * manually remove null values * update testnet-external/pregenesis.sh * apply to dev/staging genesis (cherry picked from commit 98464cb) # Conflicts: # protocol/testing/testnet-external/pregenesis.sh * resolve merge conflict --------- Co-authored-by: ttl33 <19664986+ttl33@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
gov.params.min_initial_deposit_ratioto 0.2 (=20%) to avoid gov proposal spamming.make update-sample-pregenesisTest Plan
N/A
Author/Reviewer Checklist
state-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.