SL/TP clean up #155
Merged
SL/TP clean up #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-dydx
commented
May 3, 2024
| @@ -18,7 +18,7 @@ public enum dydxSettingsStoreKey: String, CaseIterable { | |||
| public var defaultValue: Any? { | |||
| switch self { | |||
| case .language: return DataLocalizer.shared?.language | |||
| case .v4Theme: return dydxThemeType.dark.rawValue | |||
There was a problem hiding this comment.
i checked this change with Achal
ruixhuang
approved these changes
May 3, 2024
mike-dydx
added a commit
that referenced
this pull request
Aug 20, 2024
* clean up * default to classic_dark instead of dark * display oracle price and entry price as dollar formatted values * handle pendingOrders == 0 * call on edited only when focused
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* clean up * default to classic_dark instead of dark * display oracle price and entry price as dollar formatted values * handle pendingOrders == 0 * call on edited only when focused
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* clean up * default to classic_dark instead of dark * display oracle price and entry price as dollar formatted values * handle pendingOrders == 0 * call on edited only when focused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links (dYdX Internal Use Only)
Linear Ticket: MOB-447 : Test on small devices
Description
Before/After Screenshots or Videos