feat: add call to prepopulate account cache when local wallet is set #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aforaleka
added a commit
to dydxprotocol/v4-clients
that referenced
this pull request
Sep 25, 2024
motivation: - in FE, when creating the first transaction (e.g. placing a short term order after web app starts), we need to query account as part of the tx to get the account number before sending the place order message. - we can actually pre populate the account number cache earlier (i.e. app starts / clients initialized with address) so it doesn't have to be a blocker - once timestamp nonce is enabled, we will no longer need to fetch account seq number, so this will also help eliminate the round trip time blocker when placing a stateful order first change: - add `populateAccountNumberCache` function testing: - tested locally / integration with FE app dydxprotocol/v4-web#1062 - backwards compatible
moo-onthelawn
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing:
setting breakpoints and verifying that this is set (both when remember me is enabled + after connecting wallet)
placing a short term order right away:
