feat: sort wallets [OTE-825] #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yogurtandjam
force-pushed
the
jerms+tina/OTE-825_sort-wallets-and-show-default
branch
from
10e3242
to
933ca3b
Compare
yogurtandjam
force-pushed
the
jerms+tina/OTE-825_sort-wallets-and-show-default
branch
from
933ca3b
to
1e73dcf
Compare
tinaszheng
reviewed
Sep 25, 2024
src/hooks/useDisplayedWallets.ts
Outdated
Comment on lines
63
to
75
| const metamaskWallet = injectedMetaMask | ||
| ? { | ||
| connectorType: ConnectorType.Injected, | ||
| icon: injectedMetaMask.detail.info.icon, | ||
| name: injectedMetaMask.detail.info.name, | ||
| rdns: injectedMetaMask.detail.info.rdns, | ||
| } | ||
| : { | ||
| connectorType: ConnectorType.DownloadWallet, | ||
| name: WalletType.MetaMask, | ||
| downloadLink: METAMASK_DOWNLOAD_LINK, | ||
| }; | ||
|
|
There was a problem hiding this comment.
Suggested change
| const metamaskWallet = injectedMetaMask | |
| ? { | |
| connectorType: ConnectorType.Injected, | |
| icon: injectedMetaMask.detail.info.icon, | |
| name: injectedMetaMask.detail.info.name, | |
| rdns: injectedMetaMask.detail.info.rdns, | |
| } | |
| : { | |
| connectorType: ConnectorType.DownloadWallet, | |
| name: WalletType.MetaMask, | |
| downloadLink: METAMASK_DOWNLOAD_LINK, | |
| }; | |
| const metamaskWallet = injectedMetaMask ?? { | |
| connectorType: ConnectorType.DownloadWallet, | |
| name: WalletType.MetaMask, | |
| downloadLink: METAMASK_DOWNLOAD_LINK, | |
| }; | |
There was a problem hiding this comment.
injectedMetaMask isn't the right format D: it needs to go through the same transformation that we have in the .map function
src/hooks/useDisplayedWallets.ts
Outdated
| const enabledInjectedWallets = injectedWallets | ||
| .filter( | ||
| (wallet) => | ||
| // Remove Metamask. We will show it no matter what at the front of |
There was a problem hiding this comment.
lmao, this comment got mangled 😆 what happened to the second line?!
yogurtandjam
force-pushed
the
jerms+tina/OTE-825_sort-wallets-and-show-default
branch
from
25cbcee
to
bab5d61
Compare
yogurtandjam
force-pushed
the
jerms+tina/OTE-825_sort-wallets-and-show-default
branch
from
bab5d61
to
32aace9
Compare
tinaszheng
approved these changes
Sep 25, 2024
yogurtandjam
deleted the
jerms+tina/OTE-825_sort-wallets-and-show-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorts wallets according to spec https://linear.app/dydx/issue/OTE-825/sort-for-wallets-show-default-wallets-and
metamask
phantom
keplr
^ these three will go first and default to a download link if the extension isn't already installed
walletconnect
coinbase
email or social (privy)
coinbase
okx wallet
https://www.loom.com/share/01711f85a43045fc9e252f91ccf3b352