Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eta in receipt [OTE-831] #1069

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

yogurtandjam
Copy link
Contributor

uses the new state property estimatedRouteDurationSeconds

Copy link

linear bot commented Sep 26, 2024

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 9:07pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 9:07pm

@@ -111,13 +110,6 @@ export const DepositButtonAndReceipt = ({

const showExchangeRate = typeof summary?.exchangeRate === 'number';
const showMinDepositAmount = typeof summary?.toAmountMin === 'number';
const fallbackRouteDuration = stringGetter({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might still want a fallback? 🤔

Copy link
Contributor

@tyleroooo tyleroooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seeeeems fine, fallback is up to you

@yogurtandjam yogurtandjam merged commit 6a43b3e into main Sep 26, 2024
9 checks passed
@yogurtandjam yogurtandjam deleted the jerms/OTE-831_update-eta-in-receipt branch September 26, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants