chore: Add Hotjar integration #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@2dpetkov is attempting to deploy a commit to the dYdX Trading Team on Vercel. A member of the Team first needs to authorize it. |
2dpetkov
commented
Jun 10, 2024
2dpetkov
force-pushed
the
ddp-upstream-add-hotjar-inject
branch
2 times, most recently
from
da75a2a
to
857ee56
Compare
2dpetkov
force-pushed
the
ddp-upstream-add-hotjar-inject
branch
from
857ee56
to
61fe70e
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aforaleka
reviewed
Jul 1, 2024
aforaleka
reviewed
Jul 1, 2024
| @@ -37,6 +37,7 @@ jobs: | |||
| run: | | |||
| pnpm run build | |||
| pnpm run build:inject-amplitude | |||
| pnpm run build:inject-hotjar | |||
There was a problem hiding this comment.
fyi that this workflow is no longer used!
There was a problem hiding this comment.
shall I then drop this change?
There was a problem hiding this comment.
all good to keep -- i'll do another pass later on to remove unused workflows!
aforaleka
reviewed
Jul 1, 2024
|
|
||
| <b>To use with dydxprotocol/v4-web:</b> | ||
| 1. Hotjar account with Site Id and Hotjar version. | ||
| 2. Add Site Id and Hotjar version in Github > Secrets and Variables > Actions as `HOTJAR_SITE_ID` and `HOTJAR_VERSION` |
There was a problem hiding this comment.
ah the instruction for amplitude was outdated - we can keep this, but in reality the variables only need to be added on vercel
There was a problem hiding this comment.
confirming that DOS's prod deployment will have that in Vercel ✅
fix typo Co-authored-by: aleka <aforaleka@gmail.com>
aforaleka
approved these changes
Jul 1, 2024
This was referenced Jul 3, 2024
Merged
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build:inject-analyticsnpm script, so that the Vercel custom build command limitation of 256 characters is not hit when all scripts are included