Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor repo handling into SubGitRepo class #63

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Grokzen
Copy link
Collaborator

@Grokzen Grokzen commented Aug 25, 2023

Fixes #24
Fixes #33
Fixes #45
Fixes #56

…from SubGit class into it's own contained class SubGitRepo that enables simpler consumption of data/values

Refactor "subgit status" command to use this new repo handling code
Fixed a logic bug with clone-point
Minor other minor fixes
Removed some unused functions that will be converted later
@Grokzen Grokzen requested a review from holmboe September 1, 2023 12:43
@Grokzen Grokzen marked this pull request as ready for review September 1, 2023 12:44
Copy link
Contributor

@holmboe holmboe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this is good but see my comment in #33. I think this should be resorted before merging this.

subgit/repo.py Outdated Show resolved Hide resolved
subgit/repo.py Outdated Show resolved Hide resolved
Change out some prints to proper log messages
Refactor out the Yes/No string convert to a generic helper function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants