Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cornercase with _check_remote #64

Open
Grokzen opened this issue Aug 31, 2023 · 0 comments
Open

Cornercase with _check_remote #64

Grokzen opened this issue Aug 31, 2023 · 0 comments

Comments

@Grokzen
Copy link
Collaborator

Grokzen commented Aug 31, 2023

When running this method def _check_remote(self, repo): on a repo with a specific set of setup it will trigger false-positive case.

So if we have a cloned repo say pykwalify, and we have it around for some time. Then on the remote a feature branch named f/foobar was removed due to it being merged in github in a PR, then we will get a diff the next time the _check_remote method is called because the logic is written so that if there is a mismatch between the local and remote we assume something is wrong. And we treat this diff as the same as the repo would have a commit ahead of the remote or some uncommitted file locally.

The fix is probably to make the checks much more specific in the method and have corner cases where it should not be treated as a dirty repo.

The one possible exception to this is that in the case i manually create a branch locally that is not pushed to remote it could be seen as dirty but in a legit way counter to the above text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant