Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Model represents entity #1219

Merged
merged 27 commits into from
Nov 21, 2021
Merged

[v3] Model represents entity #1219

merged 27 commits into from
Nov 21, 2021

Conversation

fishcharlie
Copy link
Member

Summary:

This PR changes the behavior of Model to represent an entity and adds the concept of Table.

Type (select 1):

  • Bug fix
  • Feature implementation
  • Documentation improvement
  • Testing improvement
  • Test added to report bug (GitHub issue #--- @---)
  • Something not listed here

Is this a breaking change? (select 1):

  • 🚨 YES 🚨
  • No
  • I'm not sure

Is this ready to be merged into Dynamoose? (select 1):

  • Yes
  • No

Are all the tests currently passing on this PR? (select 1):

  • Yes
  • No

Other:

  • I have read through and followed the Contributing Guidelines
  • I have searched through the GitHub pull requests to ensure this PR has not already been submitted
  • I have updated the Dynamoose documentation (if required) given the changes I made
  • I have added/updated the Dynamoose test cases (if required) given the changes I made
  • I have ensured the following commands are successful from the root of the project directory
    • npm test
    • npm run lint
  • I agree that all changes made in this pull request may be distributed and are made available in accordance with the Dynamoose license
  • All of my commits and commit messages are detailed, explain what changes were made, and are easy to follow and understand
  • I have filled out all fields above

@vercel
Copy link

vercel bot commented Jun 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/dynamoose/dynamoose/B34UekJ35vwT1wXUVPNY6XsEMKFk
✅ Preview: https://dynamoose-git-modelrepresentsentity-dynamoose.vercel.app

[Deployment for a75b468 failed]

@github-actions
Copy link
Contributor

This pull request is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 3 days.

@github-actions
Copy link
Contributor

This pull request is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 3 days.

@fishcharlie
Copy link
Member Author

fishcharlie commented Sep 11, 2021

Next steps:

@fishcharlie fishcharlie mentioned this pull request Sep 11, 2021
69 tasks
# Conflicts:
#	lib/Model/index.ts
#	package-lock.json
#	package.json
#	test/types/Model.ts
#	test/unit/Model.js
# Conflicts:
#	lib/Model/index.ts
#	test/unit/Model.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant