-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing docs pertaining to TypeScript support #1275
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/dynamoose/dynamoose/HwTz3zoBTrjuovSooTxE531hDJd6 |
TypeScript support was added in v2.1.0 😃 |
Ah really... 😅 I couldn't seem to even find package.json
Works fine on 3.0.0-alpha3, however! Edit: Ah, got it. With my amazing git history skills it seems |
@RickvdP Take a look at https://github.com/dynamoose/dynamoose/blob/v3/PENDING_CHANGELOG.md. That is the pending changelog for v3. |
@RickvdP If you see documentation that references |
@fishcharlie Allright, not sure how I got there but checking my history I've apparently been on the v3 docs all this time... Looking like a fool while trying to be a good open-source citizen 😁 The pre-release branch is still off on the main website though! Any idea on when v3 becomes available as a stable release? |
Never! Contributions are always welcome and HIGHLY appreciated.
So that was written when a The README file is. So instead of updating the code, I'd suggest just adding a link to the README branch strategy (https://github.com/dynamoose/dynamoose#branch-strategy) to that page. Additionally it might be a good idea to add a link to that Pending Changelog for the v3 branch in the README. The reason why I'm against updating it, is that I don't want to set a precedent that the documentation will be updated whenever we switch between prerelease versions (or don't have any prerelease versions). That would require a lot of overhead, and unless someone wants to automate that process, I'm unwilling to do that work.
I currently have a local checkout with a bunch of merge conflicts. We have merge conflicts between Then after that, #1219 needs to be finished, and merged. Then, it's finishing the todo list on #1040 and getting more testers. TL;DR. still have a LOT of work to do. Any contributions are always welcome! I've tried to make it as transparent as possible where I'm at, what I've done, what still needs to be done, etc. If you do want to help, all I expect is that you communicate on those same issues and PRs, so that others (and myself) know what is already being worked on so that we don't duplicate work. I am going to close this PR tho. The changes I'm requesting are pretty different from the original intent. I'd be happy to reopen if you believe I'm wrong or have arguments for something different tho. |
Summary:
As I just started using Dynamoose I didn't quite get why the fancy TypeScript typings didn't work - until I realised
dynamoose/dist/Item
actually doesn't exist on the v2 branch.I updated the docs to better reflect this, as this info (or any info pertaining the differences of v2 and v3 actually) was not clear in the docs.
Additionally there is currently no
beta
tag in npm, just analpha
one. Those terms seem to be used interchangeably without clear differentiation what Dynamoose users can expect of either types of releases. Alpha sounds a bit scary - but the docs actually promote usage, sounding a bit more like a beta to me. Avoiding the full semantics discussion, I changed the docs to what currently works, which isdynamoose@alpha
😃 .Type (select 1):
Is this a breaking change? (select 1):
Is this ready to be merged into Dynamoose? (select 1):
Are all the tests currently passing on this PR? (select 1):
Other:
npm test
npm run lint